Skip to content

Update serial_api.c #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2014
Merged

Update serial_api.c #270

merged 2 commits into from
Apr 22, 2014

Conversation

cfb95
Copy link
Contributor

@cfb95 cfb95 commented Apr 20, 2014

add UART_3 at pins PB_10 and PB_11

add UART_3 at pins PB_10 and PB_11
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2014

Hello,

have you signed the mbed contribution agreement?

I am wondering why you have created all those patch branches with just small changes? Why you don't merge them all into one and once it's complete, it gets pushed to the master.

Regards,
0xc0170

@cfb95
Copy link
Contributor Author

cfb95 commented Apr 20, 2014

ok,
now i've signed contribution agreement!

well, i dont know how to change more than one file using only one pull
request...

Thanks for your great work at Mbed

2014-04-20 10:34 GMT-04:00 Martin Kojtal [email protected]:

Hello,

have you signed the mbed contribution agreement?

I am wondering why you have created all those patch branches with just
small changes? Why you don't merge them all into one and once it's
complete, it gets pushed to the master.

Regards,
0xc0170


Reply to this email directly or view it on GitHubhttps://github.com//pull/270#issuecomment-40896143
.

@Sissors
Copy link
Contributor

Sissors commented Apr 21, 2014

Just don't make a new branch for every file you change. If you keep it in one branch new changes are automatically included in the pull request.

@cfb95
Copy link
Contributor Author

cfb95 commented Apr 21, 2014

Ok.
Excuse the problem caused.
Thanks!

2014-04-21 3:30 GMT-04:00 Sissors [email protected]:

Just don't make a new branch for every file you change. If you keep it in
one branch new changes are automatically included in the pull request.


Reply to this email directly or view it on GitHubhttps://github.com//pull/270#issuecomment-40921066
.

@cfb95
Copy link
Contributor Author

cfb95 commented Apr 21, 2014

I've to rewrite all changes previously made using only one branch?
Or is for future changes only?

Thanks

2014-04-21 3:30 GMT-04:00 Sissors [email protected]:

Just don't make a new branch for every file you change. If you keep it in
one branch new changes are automatically included in the pull request.


Reply to this email directly or view it on GitHubhttps://github.com//pull/270#issuecomment-40921066
.

@bogdanm
Copy link
Contributor

bogdanm commented Apr 22, 2014

Is it for future changes only, thanks.

bogdanm added a commit that referenced this pull request Apr 22, 2014
@bogdanm bogdanm merged commit 14ad877 into ARMmbed:master Apr 22, 2014
bridadan pushed a commit that referenced this pull request Jun 21, 2016
Move arg types into function declaration
ccli8 pushed a commit to ccli8/mbed-os that referenced this pull request Aug 13, 2024
* Reactivate block device tests

* Oops missed some CMake files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants