STM32F4 - Add low power timer #2760

svastm · 2016-09-21T07:56:03Z

This PR add a low power timer implementation for STM32F0 targets.

Concern:

NUCLEO_F411RE
NUCLEO_F401RE
DISCO_F429ZI
NUCLEO_F446RE
NUCLEO_F410RB
DISCO_F469NI
NUCLEO_F446ZE
B96B_F446VE

Results

This is failing on GCC due to this issue GCC - hardfault in mktime with irq disabled #2647

Tests

ARM

 +-------------------+---------------+---------------------------------------+-------------------------------------+--------+--------+---------+--------------------+
 | target            | platform_name | test suite                            | test case                           | passed | failed | result  | elapsed_time (sec) |
 +-------------------+---------------+---------------------------------------+-------------------------------------+--------+--------+---------+--------------------+
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 1ms LowPowerTimeout                 | 1      | 0      | OK      | 0.05               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 1sec LowPowerTimeout                | 1      | 0      | OK      | 1.05               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 1sec LowPowerTimeout from deepsleep | 0      | 0      | SKIPPED | 0.0                |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 1sec LowPowerTimeout from sleep     | 1      | 0      | OK      | 1.06               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 500us LowPowerTimeout               | 1      | 0      | OK      | 0.05               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 5sec LowPowerTimeout                | 1      | 0      | OK      | 5.05               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 1ms lp_ticker                       | 1      | 0      | OK      | 0.04               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 1s lp_ticker                        | 1      | 0      | OK      | 1.04               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 1s lp_ticker deepsleep              | 0      | 0      | SKIPPED | 0.0                |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 1s lp_ticker sleep                  | 1      | 0      | OK      | 1.05               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 500us lp_ticker                     | 1      | 0      | OK      | 0.05               |
 | NUCLEO_F410RB-ARM | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 5s lp_ticker                        | 1      | 0      | OK      | 5.04               |
 +-------------------+---------------+---------------------------------------+-------------------------------------+--------+--------+---------+--------------------+

GCC_ARM

Fail

IAR

 +-------------------+---------------+---------------------------------------+-------------------------------------+--------+--------+---------+--------------------+
| target            | platform_name | test suite                            | test case                           | passed | failed | result  | elapsed_time (sec) |
+-------------------+---------------+---------------------------------------+-------------------------------------+--------+--------+---------+--------------------+
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 1ms LowPowerTimeout                 | 1      | 0      | OK      | 0.05               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 1sec LowPowerTimeout                | 1      | 0      | OK      | 1.05               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 1sec LowPowerTimeout from deepsleep | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 1sec LowPowerTimeout from sleep     | 1      | 0      | OK      | 1.06               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 500us LowPowerTimeout               | 1      | 0      | OK      | 0.05               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_drivers-lp_timeout | 5sec LowPowerTimeout                | 1      | 0      | OK      | 5.05               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 1ms lp_ticker                       | 1      | 0      | OK      | 0.05               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 1s lp_ticker                        | 1      | 0      | OK      | 1.04               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 1s lp_ticker deepsleep              | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 1s lp_ticker sleep                  | 1      | 0      | OK      | 1.05               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 500us lp_ticker                     | 1      | 0      | OK      | 0.04               |
| NUCLEO_F410RB-IAR | NUCLEO_F410RB | mbed-os-tests-mbed_hal-lp_ticker      | 5s lp_ticker                        | 1      | 0      | OK      | 5.04               |
+-------------------+---------------+---------------------------------------+-------------------------------------+--------+--------+---------+--------------------+

sg- · 2016-09-22T06:02:16Z

hal/targets/hal/TARGET_STM/TARGET_STM32F4/rtc_api.c

@@ -39,12 +40,31 @@ static int rtc_inited = 0;

 static RTC_HandleTypeDef RtcHandle;

+#if DEVICE_RTC_LSI


DEVICE_ reserved for device_has list. macros can use STM or just RTC_LSI

sg- · 2016-09-22T06:02:28Z

hal/targets/hal/TARGET_STM/TARGET_STM32F4/rtc_api.c

    RtcHandle.Init.OutPut         = RTC_OUTPUT_DISABLE;
    RtcHandle.Init.OutPutPolarity = RTC_OUTPUT_POLARITY_HIGH;
    RtcHandle.Init.OutPutType     = RTC_OUTPUT_TYPE_OPENDRAIN;

    if (HAL_RTC_Init(&RtcHandle) != HAL_OK) {
        error("RTC error: RTC initialization failed.");
    }
+
+#if DEVICE_LOWPOWERTIMER
+#if DEVICE_RTC_LSI


same as above about DEVICE_

sg- · 2016-09-22T06:02:47Z

hal/targets/hal/TARGET_STM/TARGET_STM32F4/rtc_api.c

@@ -129,6 +159,7 @@ void rtc_free(void)
    RCC_OscInitStruct.LSIState       = RCC_LSI_OFF;
    RCC_OscInitStruct.LSEState       = RCC_LSE_OFF;
    HAL_RCC_OscConfig(&RCC_OscInitStruct);
+
 #if DEVICE_RTC_LSI


same as above about DEVICE_

sg- · 2016-09-22T06:03:23Z

@svastm can this be rebased and conflicts resolved?

svastm · 2016-09-22T08:47:58Z

rebased

svastm · 2016-09-22T08:50:20Z

hal/targets.json

@@ -862,7 +862,8 @@
        "progen": {"target": "nucleo-f446ze"},
        "detect_code": ["0778"],
        "macros": ["TRANSACTION_QUEUE_SIZE_SPI=2"],
-        "device_has": ["ANALOGIN", "ANALOGOUT", "CAN", "ERROR_RED", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SERIAL_FC", "SLEEP", "SPI", "SPISLAVE", "SPI_ASYNCH", "STDIO_MESSAGES"]
+        "device_has": ["ANALOGIN", "ANALOGOUT", "CAN", "ERROR_RED", "I2C", "I2CSLAVE", "INTERRUPTIN", "LOWPOWERTIMER", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SERIAL_FC", "SLEEP", "SPI", "SPISLAVE", "SPI_ASYNCH", "STDIO_MESSAGES"],
+        "release_versions": ["2", "5"]


@LMESTM release_version has been removed by accident in e68b550 ?

Looks like it.

svastm · 2016-09-27T11:27:49Z

@sg- I don't understand the needs: work label.

sg- · 2016-09-27T16:20:27Z

There is a conflict or something blocking the next step, CI

Conflicting files
hal/targets.json

Enable the low power timer for the following targets: - NUCLEO_F411RE - NUCLEO_F401RE - DISCO_F429ZI - NUCLEO_F446RE - NUCLEO_F410RB - DISCO_F469NI - NUCLEO_F446ZE - B86B_F446VE

svastm · 2016-09-28T08:39:16Z

Rebased

0xc0170 · 2016-09-28T13:15:51Z

@svastm Can you address DEVICE_ reserved for device_has list. macros can use STM or just RTC_LSI comment?

svastm · 2016-09-28T13:20:10Z

@0xc0170 Yes, I have opened another PR #2816 to rename this macro over all the targets.

sg- · 2016-09-28T16:38:41Z

/morph test

sg- · 2016-09-28T16:39:52Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-09-28T16:40:12Z

[Build ${MBED_BUILD_ID}]
FAILURE: Something went wrong when building and testing.

sg- · 2016-09-28T16:44:37Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-09-28T18:07:41Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 982

All builds and test passed!

mbed-bot · 2016-09-28T18:37:34Z

[Build 994]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

sg- reviewed Sep 22, 2016

View reviewed changes

sg- added the needs: CI label Sep 22, 2016

svastm force-pushed the lp_timer_f4 branch from 5931ff6 to 7151771 Compare September 22, 2016 08:46

svastm commented Sep 22, 2016

View reviewed changes

sg- added needs: work and removed needs: CI labels Sep 22, 2016

svastm force-pushed the lp_timer_f4 branch from 7151771 to 71db90c Compare September 26, 2016 14:37

svastm mentioned this pull request Sep 26, 2016

STM32 - Rename RTC_LSI #2816

Merged

3 tasks

svastm added 2 commits September 28, 2016 09:31

STM32F4 - Add low power timer

21b11a2

STM32F4 - Enable the low power timer

0766d39

Enable the low power timer for the following targets: - NUCLEO_F411RE - NUCLEO_F401RE - DISCO_F429ZI - NUCLEO_F446RE - NUCLEO_F410RB - DISCO_F469NI - NUCLEO_F446ZE - B86B_F446VE

svastm force-pushed the lp_timer_f4 branch from 71db90c to 0766d39 Compare September 28, 2016 08:38

sg- added needs: CI and removed needs: work labels Sep 28, 2016

sg- added ready for merge and removed needs: CI labels Sep 28, 2016

sg- merged commit 3f9a04c into ARMmbed:master Sep 28, 2016

sg- added the release-version: 5.2.0 label Sep 28, 2016

sg- removed the ready for merge label Sep 28, 2016

		@@ -39,12 +40,31 @@ static int rtc_inited = 0;

		static RTC_HandleTypeDef RtcHandle;

		#if DEVICE_RTC_LSI

STM32F4 - Add low power timer #2760

STM32F4 - Add low power timer #2760

Uh oh!

Conversation

svastm commented Sep 21, 2016

Concern:

Results

Tests

Uh oh!

sg- Sep 22, 2016

Choose a reason for hiding this comment

Uh oh!

sg- Sep 22, 2016

Choose a reason for hiding this comment

Uh oh!

sg- Sep 22, 2016

Choose a reason for hiding this comment

Uh oh!

sg- commented Sep 22, 2016

Uh oh!

svastm commented Sep 22, 2016

Uh oh!

svastm Sep 22, 2016

Choose a reason for hiding this comment

Uh oh!

sg- Sep 22, 2016

Choose a reason for hiding this comment

Uh oh!

svastm commented Sep 27, 2016

Uh oh!

sg- commented Sep 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svastm commented Sep 28, 2016

Uh oh!

0xc0170 commented Sep 28, 2016

Uh oh!

svastm commented Sep 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sg- commented Sep 28, 2016

Uh oh!

sg- commented Sep 28, 2016

Uh oh!

mbed-bot commented Sep 28, 2016

Uh oh!

sg- commented Sep 28, 2016

Uh oh!

mbed-bot commented Sep 28, 2016

Result: SUCCESS

Output

Uh oh!

mbed-bot commented Sep 28, 2016

Uh oh!

Uh oh!

sg- commented Sep 27, 2016 •

edited

Loading

svastm commented Sep 28, 2016 •

edited

Loading