RNG HAL addition #2765
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* mbed Microcontroller Library | ||
| * Copyright (c) 2016 ARM Limited | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #if defined(DEVICE_TRNG) | ||
|
|
||
| #include "hal/trng_api.h" | ||
|
|
||
| int mbedtls_hardware_poll( void *data, unsigned char *output, size_t len, size_t *olen ) { | ||
| trng_t trng_obj; | ||
| trng_init(&trng_obj); | ||
| int ret = trng_get_bytes(&trng_obj, output, len, olen); | ||
| trng_free(&trng_obj); | ||
| return ret; | ||
| } | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* mbed Microcontroller Library | ||
| * Copyright (c) 2016 ARM Limited | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| #ifndef MBED_TRNG_API_H | ||
| #define MBED_TRNG_API_H | ||
|
|
||
| #include <stddef.h> | ||
| #include "device.h" | ||
|
|
||
| #if DEVICE_TRNG | ||
|
|
||
| /** TRNG HAL structure. trng_s is declared in the target's HAL | ||
| */ | ||
| typedef struct trng_s trng_t; | ||
|
|
||
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif | ||
|
|
||
| /** | ||
| * \defgroup hal_trng TRNG hal functions | ||
| * @{ | ||
| */ | ||
|
|
||
| /** Initialize the TRNG peripheral | ||
| * | ||
| * @param obj The TRNG object | ||
| */ | ||
| void trng_init(trng_t *obj); | ||
|
|
||
| /** Deinitialize the TRNG peripheral | ||
| * | ||
| * @param obj The TRNG object | ||
| */ | ||
| void trng_free(trng_t *obj); | ||
|
|
||
| /** Get random data from TRNG peripheral | ||
| * | ||
| * @param obj The TRNG object | ||
| * @param output The pointer to an output array | ||
| * @param length The size of output data, to avoid buffer overwrite | ||
| * @param output_length The length of generated data | ||
| * @return 0 success, -1 fail | ||
| */ | ||
| int trng_get_bytes(trng_t *obj, uint8_t *output, size_t length, size_t *output_length); | ||
|
|
||
| /**@}*/ | ||
|
|
||
|
There was a problem hiding this comment. We also would need a mbed TLS will call this function automatically and use this value to calculate how many times we have to poll to achieve the configured level of cryptographic strength. There was a problem hiding this comment. We may want to put a reference in a comment on how to estimate the entropy of a source. Section 6 in the standard: http://csrc.nist.gov/publications/drafts/800-90/sp800-90b_second_draft.pdf describes it in great detail with easy to follow implementation instructions. There was a problem hiding this comment. You probably discussed this with the others, but just to be sure I write it here too: The |
||
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
||
| #endif | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,10 @@ struct sleep_s { | |
| int powerdown; | ||
| }; | ||
|
|
||
| struct trng_s { | ||
| uint8_t dummy; | ||
| }; | ||
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might just be a cosmetic change, but perhaps this should be
#if defined(DEVICE_TRNG)?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to change it this morning then realized this is how it is within HAL (if we go that path, should be fixed everywhere). lets keep it as it is