callback - Fixed parameter misname #2817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problematic line: memcpy(&_func, obj, sizeof obj); Should be: memcpy(&_func, method, sizeof method); Introduced during renaming of callback arguments for clarity: ARMmbed#2794
|
/morph test |
|
👍 |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 953 All builds and test passed! |
|
LGTM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problematic line:
Should be:
Introduced during renaming of callback arguments for clarity: #2794
Unfortunately, the type is hidden by the
memcpysince method is shoved into an opaque member-function-pointer type. A generic template solution may have avoided this slip up.This is a quick patch to fix master, I will look into why the tests did not catch this mistake.
Thanks to @kjbracey-arm for tracking this down.