TESTS TOOLS - fix warnings #2818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd of greentea_serial.h
Some compiler will trigger warnings if code is located after the exit function because this function never returns (by the standard...).
This change isolate properly functions and variable declared when MBED_STACK_STATS_ENABLED is on.
|
retest uvisor |
6 similar comments
|
retest uvisor |
|
retest uvisor |
|
retest uvisor |
|
retest uvisor |
|
retest uvisor |
|
retest uvisor |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 957 All builds and test passed! |
adbridge
reviewed
Sep 27, 2016
| @@ -123,7 +123,6 @@ static int32_t utest_us_ticker_run() | |||
| callback(); | |||
| } | |||
| } | |||
| return 0; | |||
There was a problem hiding this comment.
Will this not then complain about a function expecting to return a value but not supplying one?
There was a problem hiding this comment.
No, the compilers (ARMCC, GCC and IAR) doesn't complain because this functions never returns.
Actually the compiler was complaining of the return statement because it can't be reached.
adbridge
reviewed
Sep 27, 2016
|
|
||
| static void send_heap_info(void); | ||
| #if defined(MBED_STACK_STATS_ENABLED) && MBED_STACK_STATS_ENABLED |
There was a problem hiding this comment.
This looks a weird construct why not just
#ifdef MBED_STACK_STATS_ENABLED ?
|
Couple of comments @pan- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix warnings issued by ARMCC, IAR and GCC when compiling utest and greentea.