TARGET_NRF5: Removed waiting for TX completed from 'serial_putc()'. #2822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erial_init()' to allow passing tests MBED_37/38.
anangl
changed the title
|
retest uvisor |
1 similar comment
|
retest uvisor |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 966 All builds and test passed! |
|
@anangl There is a conflict that needs to be resolved. |
* 'master' of https://github.com/ARMmbed/mbed-os: (63 commits) [XDOT_L151] add IAR support Modify mbedtls scripts to add config-no-entropy.h Remove extra spaces [XDOT_L151] include xDot in mbed 5 releases [STM32F429ZI] INITIAL_SP correction [STM32F091RC] patch for tests-mbedmicro-rtos-mbed-threads mbedtls trng - remove MBEDTLS_ENTROPY_HARDWARE_ALT targets - add TRNG device_has to STM32F7 targets mbedtls - move TRNG mbed impl into platform folder TRNG HAL - fix length doc wording for get_bytes HAL TRNG - add dummy variable to empty structs TRNG - protect HAL implementation if DEVICE_TRNG is not defined TRNG - remove set seed function HAL - RNG rename to TRNG HAL - rng nuvoton cleanup code style RNG - fix warnings due to obj not used for some targets RNG - rename rng_get_numbers to rng_get_bytes mbedtls - mbed wrapper rename to mbed_rng HAL: Add rng set seed value function NUMAKER_PFM_NUC472: Add RGN HAL API implementation ... # Conflicts: # hal/targets/hal/TARGET_NORDIC/TARGET_NRF5/serial_api.c
|
Resolved. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 975 All builds and test passed! |
|
@mbed-bot: TEST HOST_OSES=ALL |
|
[Build 996] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This waiting was earlier added (by me) to make tests MBED_37 and MBED_38 pass. I saw similar code in other ports, EFM32 for instance.
But obviously, this has a performance penalty, especially significant in case 'serial_putc' is called from an interrupt handler. Hence, I moved it to 'serial_init()'.