[tools] Making memap output consistent across output formats #2834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the output from memap.py was not consistent across all output formats. This issue stemmed from the fact that a few important calculations were being performed at output generation time. This has been moved to the 'parse' function and saved for future use by the 'generate' functions. Because this commit saves more data to the MemapParser instance, there were some name collisions. The public member 'mem_summary' has been renamed to 'mem_report'. 'mem_report' contains the data structure used by the json generator. This includes both the section data and the memory summary. The 'mem_summary' member now just contains the summary. The summary includes total allocated heap, total static RAM, etc.
theotherjimmy
approved these changes
Sep 27, 2016
|
LGTM |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 979 All builds and test passed! |
bridadan
force-pushed
the
memap-consolidate
branch
from
eecf5b9 to
abb6d26
Compare
|
@sg- should be ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where the output from memap.py was not
consistent across all output formats. This issue stemmed from the fact
that a few important calculations were being performed at output
generation time. This has been moved to the 'parse' function and saved for
future use by the 'generate' functions.
Status
IN DEVELOPMENT
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
YES
Because this commit saves more data to the MemapParser instance, there
were some name collisions. The public member 'mem_summary' has been
renamed to 'mem_report'. 'mem_report' contains the data structure used by
the json generator. This includes both the section data and the memory
summary. The 'mem_summary' member now just contains the summary. The
summary includes total allocated heap, total static RAM, etc.
Related Issue
Fixes issue in #2820
Todos