Skip to content

Correct percent printing #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2016
Merged

Correct percent printing #2859

merged 3 commits into from
Sep 30, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Sep 28, 2016

Description

Correct incremental percent printing.

Status

READY

Migrations

Nope

Todos

Steps to test or reproduce

  1. $ touch mbed-os/hal/api/Callback.h
  2. $ mbed compile

New output

[mbed] Auto-installing missing Python modules...
Building project mbed-os-example-blinky (K64F, GCC_ARM)
Scan: .
Scan: FEATURE_COMMON_PAL
Scan: FEATURE_UVISOR
Scan: FEATURE_BLE
Scan: FEATURE_IPV6
Scan: FEATURE_IPV4
Scan: FEATURE_STORAGE
Scan: mbed
Scan: env
Compile [ 89.1%]: greentea_serial.cpp
Compile [ 89.4%]: main.cpp
Compile [ 89.8%]: greentea_metrics.cpp
Compile [ 90.1%]: unity_handler.cpp
Compile [ 90.4%]: mbed-utest-shim.cpp
Compile [ 90.8%]: utest_case.cpp
Compile [ 91.1%]: utest_default_handlers.cpp
Compile [ 91.5%]: test_env.cpp
Compile [ 91.8%]: utest_greentea_handlers.cpp
Compile [ 92.2%]: utest_shim.cpp
Compile [ 92.5%]: utest_types.cpp
Compile [ 92.8%]: EthernetInterface.cpp
Compile [ 93.2%]: Socket.cpp
Compile [ 93.5%]: NetworkStack.cpp
Compile [ 93.9%]: utest_harness.cpp
Compile [ 94.2%]: SocketAddress.cpp
Compile [ 94.5%]: TCPSocket.cpp
Compile [ 94.9%]: TCPServer.cpp
Compile [ 95.2%]: UDPSocket.cpp
Compile [ 95.6%]: AnalogIn.cpp
Compile [ 95.9%]: nsapi_dns.cpp
Compile [ 96.2%]: CallChain.cpp
Compile [ 96.6%]: InterruptIn.cpp
Compile [ 96.9%]: InterruptManager.cpp
Compile [ 97.3%]: RawSerial.cpp
Compile [ 97.6%]: Serial.cpp
Compile [ 98.0%]: Ticker.cpp
Compile [ 98.3%]: Timeout.cpp
Compile [ 98.6%]: SerialBase.cpp
Compile [ 99.0%]: mbed_wait_api_rtos.cpp
Compile [ 99.3%]: RtosTimer.cpp
Compile [ 99.7%]: Thread.cpp
Compile [100.0%]: test_env.cpp
Link: mbed-os-example-blinky
Elf2Bin: mbed-os-example-blinky
+------------------+-------+-------+-------+
| Module           | .text | .data |  .bss |
+------------------+-------+-------+-------+
| Fill             |    70 |     4 |  2532 |
| Misc             | 26603 |  2212 |    88 |
| features/storage |    42 |     0 |   184 |
| hal/common       |  1560 |     4 |   277 |
| hal/targets      | 10004 |    12 |   188 |
| rtos/rtos        |    38 |     4 |     4 |
| rtos/rtx         |  5907 |    20 |  6871 |
| Subtotals        | 44224 |  2256 | 10144 |
+------------------+-------+-------+-------+
Allocated Heap: 65536 bytes
Allocated Stack: unknown
Total Static RAM memory (data + bss): 12400 bytes
Total RAM memory (data + bss + heap + stack): 77936 bytes
Total Flash memory (text + data + misc): 47520 bytes
Image: ./.build/K64F/gcc_arm/mbed-os-example-blinky.bin

@theotherjimmy
Copy link
Contributor Author

Fixes #2831

@geky
Copy link
Contributor

geky commented Sep 28, 2016

Have you considered starting the percentage at the amount already built? This gives you a good feeling for the amount of build time you would have hit had you built from scratch.

Building project mbed-os-example-blinky (K64F, GCC_ARM)
Scan: .
Scan: FEATURE_COMMON_PAL
Scan: FEATURE_UVISOR
Scan: FEATURE_BLE
Scan: FEATURE_IPV6
Scan: FEATURE_IPV4
Scan: FEATURE_STORAGE
Scan: mbed
Scan: env
Compile [ 90.3%]: greentea_serial.cpp
Compile [ 90.6%]: main.cpp
Compile [ 90.9%]: mbed-utest-shim.cpp
Compile [ 91.2%]: unity_handler.cpp
Compile [ 91.5%]: greentea_metrics.cpp
Compile [ 91.8%]: utest_case.cpp
Compile [ 92.1%]: utest_default_handlers.cpp
Compile [ 92.4%]: test_env.cpp
Compile [ 92.7%]: utest_greentea_handlers.cpp
Compile [ 93.0%]: utest_shim.cpp
Compile [ 93.3%]: utest_types.cpp
Compile [ 93.6%]: EthernetInterface.cpp
Compile [ 93.9%]: Socket.cpp
Compile [ 94.2%]: NetworkStack.cpp
Compile [ 94.5%]: utest_harness.cpp
Compile [ 94.8%]: SocketAddress.cpp
Compile [ 95.1%]: UDPSocket.cpp
Compile [ 95.4%]: TCPSocket.cpp
Compile [ 95.7%]: nsapi_dns.cpp
Compile [ 96.0%]: AnalogIn.cpp
Compile [ 96.3%]: TCPServer.cpp
Compile [ 96.6%]: CallChain.cpp
Compile [ 96.9%]: InterruptIn.cpp
Compile [ 97.2%]: InterruptManager.cpp
Compile [ 97.5%]: Ticker.cpp
Compile [ 97.8%]: RawSerial.cpp
Compile [ 98.1%]: Serial.cpp
Compile [ 98.4%]: Timeout.cpp
Compile [ 98.7%]: SerialBase.cpp
Compile [ 99.0%]: mbed_wait_api_rtos.cpp
Compile [ 99.3%]: RtosTimer.cpp
Compile [ 99.7%]: Thread.cpp
Compile [100.0%]: test_env.cpp
Link: mbed-os-example-blinky
Elf2Bin: mbed-os-example-blinky
+------------------+-------+-------+-------+
| Module           | .text | .data |  .bss |
+------------------+-------+-------+-------+
| Fill             |    70 |     4 |  2532 |
| Misc             | 26603 |  2212 |    88 |
| features/storage |    42 |     0 |   184 |
| hal/common       |  1560 |     4 |   277 |
| hal/targets      | 10004 |    12 |   188 |
| rtos/rtos        |    38 |     4 |     4 |
| rtos/rtx         |  5907 |    20 |  6871 |
| Subtotals        | 44224 |  2256 | 10144 |
+------------------+-------+-------+-------+
Allocated Heap: 65536 bytes
Allocated Stack: unknown
Total Static RAM memory (data + bss): 12400 bytes
Total RAM memory (data + bss + heap + stack): 77936 bytes
Total Flash memory (text + data + misc): 47520 bytes
Image: ./.build/K64F/gcc_arm/mbed-os-example-blinky.bin

@theotherjimmy
Copy link
Contributor Author

@geky Done. It's even simpler.

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool : )

@theotherjimmy
Copy link
Contributor Author

I have not written the regression test yet :)

@theotherjimmy
Copy link
Contributor Author

Regression tests written.

@sg-
Copy link
Contributor

sg- commented Sep 30, 2016

@theotherjimmy can you resolve conflict

@theotherjimmy
Copy link
Contributor Author

@sg- Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants