emac HAL API, WiFiInterface additions #2874

0xc0170 · 2016-09-30T12:39:15Z

Description

This PR contains:

wifi extensions - connect with extended parameter lists, connect async, scan and scan asyn
emac API
ublox emac

Notes for reviewers:
@geky raised a question about those async methods, that if we should not be consistent and provide attach, set_blocking instead of connect_async for instance. I haven't yet reworked this as it will impact the esp8266 update and ublox driver changes, thus once we are all good with the rest, we can consider this, and I can redesign it (while there are still as pull request and we can edit those).

The branch was shared for the development, therefore there are merge commits (updates from master to bring network changes like lwip2 and others), and some commits are not that clean (additions and removals later). I can clean it up as the last step. Please do not focus on git log at first.

I can also split ublox emac HAL implementation from this patch.

What's missing are tests, they will come separately, plus ublox implementation (+driver).

Status

IN DEVELOPMENT
Up for review now, still expecting some changes. Need to run some basic tests as well, ethernet should be retested that any changes in lwip_stack files do not affect its functionality.

Migrations

The wifi modules might need to extend their implementation, for instance, there's esp8266 pull request done by @bulislaw : https://github.com/ARMmbed/esp8266-driver/pull/11/files

Todos

Tests
Documentation (API at least contains doxygen)

please review @kjbracey-arm @c1728p9 @geky @bulislaw @sg- @andreaslarssonublox @lauri-piikivi

If anyone can help to test basic eth functionality, would be appreciated.

Feature wifi rebase

General refactoring of the API and new methods added: * get_rssi() - measures radio signal strenght * get_state() - returns current state (not connected, connecting, connected, error) * scan() - scans for available networks sync and async versions * connect_async() - connect to a network without blocking

Extend and rework WiFi interface

* Add details to documentation * Add timeout for async functions * Add channel parameter to connect * Add wifi_ap_t to connection cb function

HAL: Add Emac interface

Conflicts: features/net/FEATURE_IPV4/lwip-interface/EthernetInterface.cpp features/net/FEATURE_IPV4/lwip-interface/lwip_stack.c features/net/FEATURE_IPV4/lwip-interface/lwip_stack.h features/net/network-socket/WiFiInterface.h

ethernet uses eth_arch_xxx_interrupts, emac_xxx_enable_interrupts

It now accepts additional arguments, that lwipipstack do not use, thus all 0 and false for dhcp.

WifiInterface - add set_credentials

We do not want to mix Ethernet and Wifi at the moment, thus WiFiInterface should implement own connect using emac.

Conflicts: features/net/FEATURE_IPV4/lwip-interface/lwip_stack.c hal/targets.json

Currently only for IPv4. lwip was updated to accept 2 arguments for getting the ip address (buffer and length).

…d for the u-blox ODIN-W2 driver. The actually needed size has not been measured.

kjbracey · 2016-10-04T14:44:28Z

I'm happier with that final diff - it's not messing with the fundmental initialisation flow at all as far as I can see, so should be fine for both IPv4 and IPv6.

I think I would have put the "netif_add" into the connect rather than the init, but maybe you're right - if that split suits your driver, fine.

Would be nice to see a tidied up patch set, especially now there's the rename - would be possible to check the actual net diff apart from the rename.

bulislaw · 2016-10-04T14:46:03Z

Do you mean just this single commit? ae11b51

kjbracey · 2016-10-04T14:48:02Z

Do you mean just this single commit? ae11b51

No, that's the diff since your previous draft. I want to see the actual final patches versus master.

All GitHub can show me against master is your total branch, including the rename - can't easily isolate the other changes.

…reas wifi: ublox fixes to lwip and wifi

geky · 2016-10-04T15:24:00Z

This looks good, thanks for fixing the API bugs.

The only remaining issue is with NSAPI_SECURITY_UNSUPPORTED.

0xc0170 · 2016-10-04T16:32:26Z

/morph test

bridadan · 2016-10-04T19:14:25Z

/morph test

Returning a wifi access point without information regarding the security type is only valid if the security type is unknown (from the perspective of the network-socket API). For clarity in situations in which scan may return an unsupported, but known security type, type name has been changed to NSAPI_SECURITY_UNKNOWN.

mbed-bot · 2016-10-04T19:34:59Z

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

geky · 2016-10-04T19:35:32Z

/morph test

geky · 2016-10-04T22:11:08Z

Tested locally with K64F, NUCLEO_F429ZI, and NUMAKER_PFM_NUC472

mbed-bot · 2016-10-05T00:33:37Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1052

All builds and test passed!

0xc0170 · 2016-10-05T08:06:45Z

Thank you all of you for review and helping with this patch 👍

0xc0170 and others added 30 commits September 14, 2016 12:53

Merge pull request ARMmbed#2699 from bulislaw/feature_wifi_rebase

b826f0e

Feature wifi rebase

Merge pull request ARMmbed#2627 from bulislaw/feature_wifi

4fde794

Extend and rework WiFi interface

HAL: Add Emac interface

ed0dfb4

EMAC: Add emac_stack_t implementation for LWIP

ac8c2f9

EMAC: Add LWIP adaptation layer

4a6728c

WiFi: Add IPStackInterface abstraction for IP stacks

ddd65b4

WiFi: Extend WiFiInterface API and documentation

aad3e1f

* Add details to documentation * Add timeout for async functions * Add channel parameter to connect * Add wifi_ap_t to connection cb function

Merge pull request ARMmbed#2729 from bulislaw/feature_wifi

8bfd108

HAL: Add Emac interface

Merge branch 'master' into feature_wifi

20f5adb

Conflicts: features/net/FEATURE_IPV4/lwip-interface/EthernetInterface.cpp features/net/FEATURE_IPV4/lwip-interface/lwip_stack.c features/net/FEATURE_IPV4/lwip-interface/lwip_stack.h features/net/network-socket/WiFiInterface.h

K64F: add EMAC device_has

e0a48e9

lwip: add emac interrupt API

bd3a81d

ethernet uses eth_arch_xxx_interrupts, emac_xxx_enable_interrupts

lwipipstack: lwip_bringup arguments update

febf1a8

It now accepts additional arguments, that lwipipstack do not use, thus all 0 and false for dhcp.

network-sockets: revert API for static configuration

b256b2f

WifiInterface - add set_credentials

WiFiInterface: remove connect implementation

3d14c20

We do not want to mix Ethernet and Wifi at the moment, thus WiFiInterface should implement own connect using emac.

Merge branch 'master' into feature_wifi

f12676d

Conflicts: features/net/FEATURE_IPV4/lwip-interface/lwip_stack.c hal/targets.json

lwip emac - remove non-existent header inclusion

81932ee

IPStackInterface - add ip address

517f050

Currently only for IPv4. lwip was updated to accept 2 arguments for getting the ip address (buffer and length).

WifiInterface - use Callback class for callbacks

33d9565

WiFiInterface: change scope of wifi_ap_t structure

da75298

nsapi: error no ssid name correction

5ed97d5

EMAC: Add LWIP adaptation layer

a30aa8f

WiFi: Add IPStackInterface abstraction for IP stacks

7a3a580

Fixed return type for disconnect

26c3eef

Added EMAC

05974a6

Added pointer for wifi_ap_t in wifi_connect_cb_t to be able to use NULL

40cd23c

Added missing ;

b07d602

Added wifi_emac_api.cpp

2ce9039

EMAC: Fix "#if DEVICE_EMAC " usage

c80641f

WiFi: Decuple IP stack bringup and IP address provisioning

f122695

bulislaw and others added 6 commits October 4, 2016 14:38

Fix merge issues

1e7ba5f

Added function for increasing ref count.

b418fce

Fixed missing abstract connect method

8ea46ea

Fixed missing public

e87f013

Increased the stack size for the lwIP thread from 1024 to 1200. Neede…

f5675cc

…d for the u-blox ODIN-W2 driver. The actually needed size has not been measured.

Fixed mbed_lwip_get_netmask amd mbed_lwip_get_gateway

26eb5f1

Merge pull request #2 from andreaslarssonublox/feature_wifi_ublox_and…

e1a4db7

…reas wifi: ublox fixes to lwip and wifi

0xc0170 added needs: CI and removed needs: review labels Oct 4, 2016

Fix spelling error: NSAPI_SECURITY_UNSUPPORTED

febc341

geky force-pushed the feature_wifi_ublox branch from 60afa03 to 4f1eded Compare October 4, 2016 19:23

sg- added ready for merge and removed needs: CI labels Oct 5, 2016

sg- merged commit 683d7b7 into ARMmbed:master Oct 5, 2016

sg- added release-version: 5.2.0 and removed ready for merge labels Oct 5, 2016

andreaslarssonublox mentioned this pull request Oct 11, 2016

Ublox drivers #2977

Merged

2 tasks

0xc0170 deleted the feature_wifi_ublox branch September 2, 2021 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

emac HAL API, WiFiInterface additions #2874

emac HAL API, WiFiInterface additions #2874

Uh oh!

0xc0170 commented Sep 30, 2016 •

edited

Loading

Uh oh!

kjbracey commented Oct 4, 2016

Uh oh!

bulislaw commented Oct 4, 2016

Uh oh!

kjbracey commented Oct 4, 2016

Uh oh!

geky commented Oct 4, 2016 •

edited

Loading

Uh oh!

0xc0170 commented Oct 4, 2016

Uh oh!

bridadan commented Oct 4, 2016

Uh oh!

mbed-bot commented Oct 4, 2016

Uh oh!

geky commented Oct 4, 2016

Uh oh!

geky commented Oct 4, 2016

Uh oh!

mbed-bot commented Oct 5, 2016

Uh oh!

0xc0170 commented Oct 5, 2016

Uh oh!

Uh oh!

emac HAL API, WiFiInterface additions #2874

emac HAL API, WiFiInterface additions #2874

Uh oh!

Conversation

0xc0170 commented Sep 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Migrations

Todos

Uh oh!

kjbracey commented Oct 4, 2016

Uh oh!

bulislaw commented Oct 4, 2016

Uh oh!

kjbracey commented Oct 4, 2016

Uh oh!

geky commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Oct 4, 2016

Uh oh!

bridadan commented Oct 4, 2016

Uh oh!

mbed-bot commented Oct 4, 2016

Result: ABORTED

Uh oh!

geky commented Oct 4, 2016

Uh oh!

geky commented Oct 4, 2016

Uh oh!

mbed-bot commented Oct 5, 2016

Result: SUCCESS

Output

Uh oh!

0xc0170 commented Oct 5, 2016

Uh oh!

Uh oh!

0xc0170 commented Sep 30, 2016 •

edited

Loading

geky commented Oct 4, 2016 •

edited

Loading