Fix mbedtls user config and null entropy #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yanesca @sbutcher-arm : Please review |
|
Reviewed - LGTM. |
andresag01
changed the title
|
Reviewed and approved. |
1 task
|
Does this fixes #2914 ? |
|
Looks good to me as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it possible to use the default config whenever
MBEDTLS_TEST_NULL_ENTROPYinstead of the config-no-entropy.h. Furthermore, an include ofMBEDTLS_USER_CONFIG_FILEis added whenever config-no-entropy.h is in use. This makes it possible for users to use config-no-entropy.h AND customise it by providing custom config options.Status
READY
Migrations
NO
Related PRs
There are no related PRs pending for merge.
Todos
Deploy notes
This change does not require any changes, simply use mbedtls as normal.