Skip to content

Increase serial init timeout value #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

jeromecoutant
Copy link
Collaborator

Description

In my previous pull request (#2727),
I forgot to remove all the duration time with a value inferior than the default value...

Status

READY

Steps to test or reproduce

Outline the steps to test or reproduce the PR here.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 12, 2016

@bridadan @mazimkhan

@bridadan
Copy link
Contributor

@jeromecoutant Is there a reason why we want to remove the customized durations? Are you seeing unnecessary timeouts?

@jeromecoutant
Copy link
Collaborator Author

This duration looks to be the timeout value for serial init time before test start.
So it doesn't need any customization...

@bridadan
Copy link
Contributor

@jeromecoutant I believe the duration value is also used to determine if a test should TIMEOUT or not. And this can vary depending on how long the test runs. If the test is a very short test, it is often set to a smaller value so the tester isn't waiting too long for it to finish. But for long tests, this can be customized to be a larger value. So it's basically just an optimization to reduce the amount of time you're waiting for a test result from a potentially failing test.

For this reason, I don't think we'd want to mess with the customized duration values inside test.py.

@jeromecoutant
Copy link
Collaborator Author

Hi

the duration value is also used to determine if a test should TIMEOUT or not

I didn’t see this… Test timeout value looks to be set in the main.cpp file with for ex:
MBED_HOSTTEST_TIMEOUT(10);

duration value is used while executing host_test.py
with -t parameter

@bridadan
Copy link
Contributor

@jeromecoutant Ah yes, that bit totally slipped my mind! Should probably be ok. I'll run mbed 2 testing

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 1041]
FAILURE: Something went wrong when building and testing.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is from a build issue on an unrelated target, LGTM

@sg- sg- merged commit 435d5fb into ARMmbed:master Oct 19, 2016
@jeromecoutant jeromecoutant deleted the PR_Init_Time_Issue branch October 19, 2016 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants