Skip to content

ONME-2822 Binary build script mod #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Conversation

hasnainvirk
Copy link
Contributor

@hasnainvirk hasnainvirk commented Oct 14, 2016

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

  • Nanostack build script modifications to match current mbedOS baseline structure.
  • License files moved to correct location

Status

READY/IN DEVELOPMENT/HOLD

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

YES | NO

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation

Deploy notes

Notes regarding the deployment of this PR. These should note any
required changes in the build environment, tools, compilers, etc.

Steps to test or reproduce

Outline the steps to test or reproduce the PR here.

  • Binary build script is modified to follow currebt mbedOS baseline structure
  • License files are moved to the correct location.
  • Contribution.md is also moved to the correct location.

* Binary build script is modified to follow currebt mbedOS baseline structure
* License files are moved to the correct location.
* Contribution.md is also moved to the correct location.
@hasnainvirk
Copy link
Contributor Author

@SeppoTakalo , @sg-

Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@SeppoTakalo
Copy link
Contributor

There is no need to run longer tests as we are not touching any source files here.
mbed-os-cliapp build seems to fail but it has been failing always so not caused by this PR.

It needs to be fixed on separate PR.

@bridadan
Copy link
Contributor

I agree with with @SeppoTakalo that there isn't any need to run the longer running bots on this PR 👍

@bridadan
Copy link
Contributor

@sg- or @0xc0170 This should be good to merge if either of you are happy with it. I'll add the needs: review tag to indicate that we're waiting on your decision.

@sg-
Copy link
Contributor

sg- commented Oct 19, 2016

@hasnainvirk @SeppoTakalo Can you confirm the continuous-integration/jenkins/pr-head is OK?

@SeppoTakalo
Copy link
Contributor

It is OK.
Not related to this PR.

@0xc0170 0xc0170 merged commit 382cb9f into ARMmbed:master Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants