Remove k64f defines from IAR templates #3047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph export-build |
|
Looks good to me |
theotherjimmy
approved these changes
Oct 17, 2016
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
bridadan
approved these changes
Oct 17, 2016
|
No need to run other bots on this PR since this file isn't tested by them! |
|
@sarahmarshy Note, If we support custom templates, the tool exporter should clean up the common variables in the tool templates, like macros, as a user might just copy a template from their own project and I dont think we want to review all templates one by one. Progen does that therefore it was not an issue there. |
|
@0xc0170 We do not want to support custom templates, and we also do not want to have more than one template for each file. This will also prevent us from having to review the templates one by one, as there should only ever be one template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove K64F macros from IAR template. This was an oversight missed after copying progen's template file https://github.com/project-generator/project_generator/blob/master/project_generator/templates/iar.ewp#L173.
Fixes #3026
Status
READY