Fix stm32 pull overwrite #3056
Merged
Fix stm32 pull overwrite #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LMESTM I believe 3 top commits should not be part of this fix patch |
This applies the same fix as was done for F4 to solve issue ARMmbed#2638. The fix applies ell to all other families excpet STM32F1. Basically, to avoid over-writing the pull-up/-down settings, we read the current state from HW.
This fix addresses issue ARMmbed#2638 for STM32F1. The STM32F1 family has a diffeerent register set for pull-up and pull-down settings. The same principle to read HW state is applied, as in commit: [STM32] Fix pull over write to all families except registers are different. Also in this patch we make code a bit more linear. Depending on pin_index, different register and shift index must be used. Instead of checking this in several place, let's make a check at the beginning of the function and use local register and shift variables.
LMESTM
force-pushed
the
fix_stm32_pull_overwrite
branch
from
dc24be2 to
24d82d1
Compare
|
@0xc0170 thanks |
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=ALL |
|
[Build 1049] |
|
Test failure is OK, it's an issue with an unrelated platform. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 0 Test failed! |
|
Same deal for above, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for all STM32 families for reported issue #2638.
The pull-up / pull-down was over-writtent in case irq API was called after pinmap one.
Status
READY
Tests
Tests ok - no regression seen - all families tested
Nonreg_FixPullOverwrite.xlsx
Also the test reported in the issue runs fine on all tested boards when the fix is applied