Skip to content

[Exporters] Add quick print to the makefile when srec_cat is required #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2016
Merged

[Exporters] Add quick print to the makefile when srec_cat is required #3063

merged 1 commit into from
Oct 19, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Oct 18, 2016 •
edited by bridadan
Loading

Description

It just tells the user that they need srec_cat to build when they need it.

Status

READY

Reviews

@theotherjimmy
Copy link
Contributor Author

Maybe resolves #2962

@bridadan
Copy link
Contributor

@theotherjimmy Do you have a sample output? It'd probably be good to print it right before the srec step, so it's still hopefully in view if the error occurs.

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Oct 18, 2016 •
edited
Loading 

$ mbed export -i make_gcc_arm -t nrf51822
$ make 
[snip...]
'arm-none-eabi-objcopy' -O binary mbed-os-example-blinky.elf mbed-os-example-blinky.bin
'arm-none-eabi-objcopy' -O ihex mbed-os-example-blinky.elf mbed-os-example-blinky.hex
NOTE: the srec_cat binary is required to be present in your PATH. Please see http://srecord.sourceforge.net/ for more information.
srec_cat .././mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/bootloader/s110_nrf51822_8.0.0_bootloader.hex .././mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/bootloader/s130_nrf51_1.0.0_bootloader.hex .././mbed-os/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/Lib/s110_nrf51822_8_0_0/s110_nrf51822_8.0.0_softdevice.hex .././mbed-os/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/Lib/s130_nrf51822_1_0_0/s130_nrf51_1.0.0_softdevice.hex  -intel mbed-os-example-blinky.hex -intel -o mbed-os-example-blinky-combined.hex -intel --line-length=44
make[1]: srec_cat: Command not found
/home/jimbri01/src/arm-mbed/mbed-os-example-blinky/Makefile:567: recipe for target 'mbed-os-example-blinky-combined.hex' failed
make[1]: *** [mbed-os-example-blinky-combined.hex] Error 127
Makefile:25: recipe for target 'all' failed
make: *** [all] Error 2

@bridadan
Copy link
Contributor

Can the NOTE be moved right before the srec step? And perhaps link to the project page? Something like:

NOTE: the post build processing step requires the `srec_cat` tool to be present in your PATH. Please see http://srecord.sourceforge.net/ for more information.

bridadan
bridadan approved these changes Oct 18, 2016
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@screamerbg
Copy link
Contributor

LGTM

pan-
pan- approved these changes Oct 18, 2016
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sg-
Copy link
Contributor

sg- commented Oct 19, 2016

Fine for now, although I'd expect there is a python dependency that most system would already have that could do this especially of installing mbed-os requirements

@sg- sg- merged commit d6831b3 into ARMmbed:master Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

@sarahmarshy sarahmarshy sarahmarshy approved these changes

Assignees
No one assigned
Labels
release-version: 5.2.0-rc4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@theotherjimmy @bridadan @screamerbg @sg- @pan- @0xc0170 @sarahmarshy