Release candidate for mbed-os-5.2-rc4 #3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot used. We can not rely on the struct constructor to be run since wifi_emac_get_interface can be run from the OdinWiFiInterface constructor before that.
When the config store is powered down area_0_head is freed, but area_0_len is not set to 0. This causes when cfstore_realloc_ex is called, since on the first allocation it appears that the config store size is decreasing, and therefore the data is not initialized. Since the data is uninitiated various fields such as the reference can have invalid values. On GCC_ARM built with heap stats enabled this manifests as a crash due to an invalid reference count. This patch fixes this problem by setting area_0_len to 0 when the data is freed.
The function cfstore_delete_ex is written under the assumption that CFSTORE_REALLOC will never fail if the size is decreasing. Regardless of the status of CFSTORE_REALLOC the entry is removed from the config store and zeroed. This works correctly if CFSTORE_REALLOC correctly updates area_0_tail, but can lead to crashes in the case area_0_tail is left unchanged. The crash is because when iterating over the config store data, cfstore_get_next_hkvt is unable to determine the end of valid data. This patch fixes this problem by handling the realloc failure case by updating area_0_tail even if CFSTORE_REALLOC returns NULL. This patch also adds an assert to check for out of bound entries in when calling cfstore_get_next_hkvt. This allows an assert to be triggered if this bug is re-introduced, rather than a crash.
When closing a file handle remove the handle from the handle list regardless of what the reference count of the key it is pointing to is. This prevents config store from keeping a handle to file handles that have gone out of scope.
In the config store create test in test case #5 the amount of available memory is determined by fully allocating the heap. This is done multiple times to determine if there is a memory leak. This causes problems when even slight fragmentation occurs in the heap, since the size that can be allocated is decreased slightly, which the test flags as a memory leak. This patch makes memory leak detection more robust by using metrics provided by mbed_stats_heap_get. These metrics are an exact measurement of memory allocated is not changed by fragmentation. This allows the memory leak test to report correct values regardless of fragmentation.
This applies the same fix as was done for F4 to solve issue #2638. The fix applies ell to all other families excpet STM32F1. Basically, to avoid over-writing the pull-up/-down settings, we read the current state from HW.
This fix addresses issue #2638 for STM32F1. The STM32F1 family has a diffeerent register set for pull-up and pull-down settings. The same principle to read HW state is applied, as in commit: [STM32] Fix pull over write to all families except registers are different. Also in this patch we make code a bit more linear. Depending on pin_index, different register and shift index must be used. Instead of checking this in several place, let's make a check at the beginning of the function and use local register and shift variables.
Increase the IAR heap size from 48KiB to 64KiB. This give enough heap space to run the TLS encryption examples.
* Binary build script is modified to follow currebt mbedOS baseline structure * License files are moved to the correct location. * Contribution.md is also moved to the correct location.
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 919 Test failed! |
|
Tests are OK, the failure is known for on semi target - lp ticker, the rest is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.