Skip to content

Update pack-derived files, and add safely test to uVision exporter #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Oct 20, 2016

Description

The packs have been updated/the ones I checked in were out of date. Also, The flash algorithm section is entirely optional in a pack, so I added a test to prevent tracebacks when it's not present

Status

READY

Reviews

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 20, 2016

mbed export -m NUCLEO_F401RE -i uvision does not generate traceback anymore with this patch. However, I use v5.17 (have to update to 5.21 today), and dont see flash algo for this target. Should I ? or because algo is not required, some targets might not have flash algo in project files?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 20, 2016

/morph export-build

@sarahmarshy
Copy link
Contributor

If it isn't there, the debugger will certainly not start. Those targets should not be supported.

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

@sarahmarshy
Copy link
Contributor

sarahmarshy commented Oct 20, 2016

The only problem is that the continue added will generate an invalid flash dll string, potentially causing a silent fail later. We need to decide what we are going to do about absent flash algos, but that can be a later PR.

@mazimkhan
Copy link

retest uvisor

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 20, 2016

If it isn't there, the debugger will certainly not start. Those targets should not be supported.

@sarahmarshy If that's the case, we should report this, and cmsis-pack should contain that info, otherwise they are not that useful :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants