Add checks for NULL_ENTROPY and SSL_TLS in mbed OS #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbutcher-arm @yanesca |
andresag01
force-pushed
the
mbedtls-preoprocessor-checks
branch
from
c789822 to
2227b9d
Compare
|
|
||
| #if defined(MBEDTLS_TEST_NULL_ENTROPY) | ||
| #warning "MBEDTLS_TEST_NULL_ENTROPY is enabled, the application will " \ | ||
| "not be secure! Please implement hardware entropy for your platform" |
There was a problem hiding this comment.
Please change the warning to:
WARNING! MBEDTLS_TEST_NULL_ENTROPY has been enabled. This configuration is not secure and is not suitable for production use.
| #if defined(MBEDTLS_SSL_TLS_C) && !defined(MBEDTLS_TEST_NULL_ENTROPY) && \ | ||
| !defined(MBEDTLS_ENTROPY_HARDWARE_ALT) | ||
| #error "MBEDTLS_SSL_TLS_C defined, but not all prerequisites" | ||
| #endif |
There was a problem hiding this comment.
Please change the error text to:
No entropy source was found at build time, so TLS functionality is not available.
2227b9d to
509a72c
Compare
|
LGTM. |
andresag01
changed the title
|
/morph test |
|
retest uvisor |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 926 Test failed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add preprocessor checks to mbed TLS through the importer scripts to ensure that compilation fails for targets that attempt to use SSL or entropy, but these are not supported by the target.
Status
READY
Migrations
NO
Todos
Deploy notes
This causes build errors while trying to build applications that require SSL or entropy sources but the target does not support it.