[SDFileSystem] Enable / Disable serial debug. #3093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added ``void debug(bool dbg)`` method to allow enabling/disabling serial debug at runtime. + Replaced calls to ``debug`` with ``debug_if`` to prevent messges from being thrown via serial when debug is disabled. Signed-off-by: Bruno Monteiro Pires <[email protected]>
0xc0170
requested changes
Oct 24, 2016
| @@ -58,6 +58,7 @@ class SDFileSystem : public FATFileSystem { | |||
| virtual int disk_write(const uint8_t* buffer, uint32_t block_number, uint32_t count); | |||
| virtual int disk_sync(); | |||
| virtual uint32_t disk_sectors(); | |||
| void debug(bool dbg); | |||
There was a problem hiding this comment.
using tabs here? some lines in this file and the other are misaligned here on github
There was a problem hiding this comment.
Sorry, there were some tabs, i've fixed it.
* Removed missplaced tabs Signed-off-by: Bruno Monteiro Pires <[email protected]>
|
@c1728p9 please review |
0xc0170
approved these changes
Oct 25, 2016
|
Looks good to me |
|
@BrunoMPires Can you please sign https://developer.mbed.org/contributor_agreement/ ? |
|
@0xc0170 sure, just signed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
void debug(bool dbg)method to allow enabling/disablingserial debug at runtime.
debugwithdebug_ifto prevent messgesfrom being thrown via serial when debug is disabled.
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Todos
Steps to test or reproduce
sd, do not inset card.sd.debug(true)command.Signed-off-by: Bruno Monteiro Pires [email protected]