Add '-g3' flag to gcc debug flags #3295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes extra information, such as all the macro definitions present in the program
theotherjimmy
approved these changes
Nov 18, 2016
| @@ -5,7 +5,7 @@ | |||
| "-fmessage-length=0", "-fno-exceptions", "-fno-builtin", | |||
| "-ffunction-sections", "-fdata-sections", "-funsigned-char", | |||
| "-MMD", "-fno-delete-null-pointer-checks", | |||
| "-fomit-frame-pointer", "-O0", "-g"], | |||
| "-fomit-frame-pointer", "-O0", "-g3"], | |||
There was a problem hiding this comment.
Can you make this change set smaller?
|
Looks good to me. What kind of an effect does this have on build time and elf size? |
|
Quick measurements with
|
|
CI doesn't hit this profile, so shouldn't need to run the bots on this. |
0xc0170
approved these changes
Nov 21, 2016
0xc0170
added
ready for merge
release-version: 5.3.0
and removed
needs: review
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a gcc specific flag that increases debug information, most useful is allowing the expansion of macros.
http://stackoverflow.com/questions/10475040/gcc-g-vs-g3-gdb-flag-what-is-the-difference/10475077#10475077
cc @theotherjimmy, @c1728p9