DELTA_DFBM_NQ620 default configuration #3298

TsungtaWu · 2016-11-19T15:06:35Z

Slightly change on the SRC config.
And add mbed_SDK_init() for internal debug purpose.
Please kindly review this PR.

Change SRC setting to RC as default to match with hardware config. mbed_sdk_init() is added for internal debug purpose (experimental)

0xc0170 · 2016-11-21T13:52:31Z

targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/TARGET_DELTA_DFBM_NQ620/mbed_overrides.c

+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+	#define MBED_CONF_NORDIC_NRF_LF_CLOCK_SRC		(NRF_LF_SRC_RC)


Can you align this defines, should be at the beginning of the line.

Why sdk_init prints time and date? Is this intentional?

Those #define never used.

This reverts commit f821736.

TsungtaWu · 2016-11-21T16:39:36Z

Sorry, my bad.
Those three #define are redundant.
Just commit again to fix that.

Can you align this defines, should be at the beginning of the line.

Sorry, my bad. Actually, those three #define are redundant.

Why sdk_init prints time and date? Is this intentional?

YES, we intent to do that for very special reasons.

2016-11-21 21:52 GMT+08:00 Martin Kojtal [email protected]:

@0xc0170 requested changes on this pull request.

In targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/
TARGET_DELTA_DFBM_NQ620/mbed_overrides.c
#3298 (review):

+/* mbed Microcontroller Library

* Copyright (c) 2006-2013 ARM Limited

* Licensed under the Apache License, Version 2.0 (the "License");

* you may not use this file except in compliance with the License.

* You may obtain a copy of the License at

* http://www.apache.org/licenses/LICENSE-2.0

* Unless required by applicable law or agreed to in writing, software

* distributed under the License is distributed on an "AS IS" BASIS,

* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

* See the License for the specific language governing permissions and

* limitations under the License.

*/

#define MBED_CONF_NORDIC_NRF_LF_CLOCK_SRC (NRF_LF_SRC_RC)

Can you align this defines, should be at the beginning of the line.

Why sdk_init prints time and date? Is this intentional?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3298 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATeFu9Jp9EB0SowyZX8eiOQu09VkByWNks5rAaIogaJpZM4K3Rlo
.

CONFIRM to remove those #define

0xc0170 · 2016-11-29T11:59:15Z

I don't see any newer commit since the requested changes. Please push it to your branch.

TsungtaWu · 2016-11-29T16:08:29Z

Just did. 2016-11-29 19:59 GMT+08:00 Martin Kojtal <[email protected]>:

…

I don't see any newer commit since the requested changes. Please push it to your branch. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3298 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATeFu7v4kXIb5Os1ORKtBqVB91zrfa36ks5rDBOWgaJpZM4K3Rlo> .

0xc0170 · 2016-12-02T12:13:58Z

targets/targets.json

@@ -2338,6 +2338,7 @@
        "macros_add": ["BOARD_PCA10040", "NRF52_PAN_12", "NRF52_PAN_15", "NRF52_PAN_58", "NRF52_PAN_55", "NRF52_PAN_54", "NRF52_PAN_31", "NRF52_PAN_30", "NRF52_PAN_51", "NRF52_PAN_36", "NRF52_PAN_53", "S132", "CONFIG_GPIO_AS_PINRESET", "BLE_STACK_SUPPORT_REQD", "SWI_DISABLE0", "NRF52_PAN_20", "NRF52_PAN_64", "NRF52_PAN_62", "NRF52_PAN_63"],
        "device_has": ["ANALOGIN", "ERROR_PATTERN", "I2C", "I2C_ASYNCH", "INTERRUPTIN", "LOWPOWERTIMER", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SLEEP", "SPI", "SPI_ASYNCH", "SPISLAVE"],
        "release_versions": ["2", "5"],
+	"overrides": {"lf_clock_src": "NRF_LF_SRC_RC"},


nit: align overrides please

0xc0170 · 2016-12-02T12:14:11Z

targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/TARGET_DELTA_DFBM_NQ620/mbed_overrides.c

@@ -0,0 +1,21 @@
+/* mbed Microcontroller Library
+ * Copyright (c) 2006-2013 ARM Limited


should be 2016

0xc0170 · 2016-12-02T12:14:33Z

I just left 2 nits here, LGTM otherwise. Once fixed, we will run CI

fix year typo and refine targets.json platfrom setting

TsungtaWu · 2016-12-02T16:37:32Z

Fixed. Thanks for your review. 2016-12-02 20:14 GMT+08:00 Martin Kojtal <[email protected]>:

…

I just left 2 nits here, LGTM otherwise. Once fixed, we will run CI — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3298 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATeFuxQKOE6BLC0DguCC3i34jYdSyGNxks5rEAusgaJpZM4K3Rlo> .

Align the phase after all.

TsungtaWu · 2016-12-03T09:00:13Z

Sorry for my confusion. Push one more time just now. 2016-12-03 0:37 GMT+08:00 Wu Tsungta <[email protected]>:

…

Fixed. Thanks for your review. 2016-12-02 20:14 GMT+08:00 Martin Kojtal ***@***.***>: > I just left 2 nits here, LGTM otherwise. Once fixed, we will run CI > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#3298 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ATeFuxQKOE6BLC0DguCC3i34jYdSyGNxks5rEAusgaJpZM4K3Rlo> > . >

0xc0170 · 2016-12-05T13:22:45Z

/morph test

mbed-bot · 2016-12-05T14:05:40Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1200

All builds and test passed!

adbridge · 2016-12-19T14:43:07Z

This will be manually backported to 5.3.1 due to the merge remote tracking branch commit which should have been rebased prior to this PR being accepted. That merge commit creates an extra 1000 patch commits when running automatically!

TsungtaWu added 2 commits November 19, 2016 10:49

Merge remote-tracking branch 'refs/remotes/ARMmbed/master'

35f1cb0

Change default SRC setting and add mbed_sdk_init() for DELTA_DFBM_NQ620

f8d9957

Change SRC setting to RC as default to match with hardware config. mbed_sdk_init() is added for internal debug purpose (experimental)

0xc0170 requested changes Nov 21, 2016

View reviewed changes

0xc0170 added the needs: work label Nov 21, 2016

TsungtaWu added 2 commits November 22, 2016 00:33

remove the redundant #define

f821736

Those #define never used.

Revert "remove the redundant #define"

c5113e5

This reverts commit f821736.

Recommit to remove redundant #define

28e956e

CONFIRM to remove those #define

0xc0170 reviewed Dec 2, 2016

View reviewed changes

align targets.json and mbed_overrides.c

8bb74ae

fix year typo and refine targets.json platfrom setting

Align overrides phase

6cee473

Align the phase after all.

0xc0170 added needs: CI and removed needs: work labels Dec 5, 2016

0xc0170 approved these changes Dec 5, 2016

View reviewed changes

0xc0170 added release-version: 5.3.1 and removed needs: CI labels Dec 5, 2016

0xc0170 merged commit 7d4befa into ARMmbed:master Dec 5, 2016

adbridge removed the release-version: 5.3.1 label Dec 19, 2016

adbridge added a commit that referenced this pull request Dec 19, 2016

Manually patch: DELTA_DFBM_NQ620 default configuration #3298

137fb4a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DELTA_DFBM_NQ620 default configuration #3298

DELTA_DFBM_NQ620 default configuration #3298

Uh oh!

TsungtaWu commented Nov 19, 2016

Uh oh!

0xc0170 Nov 21, 2016

Uh oh!

TsungtaWu commented Nov 21, 2016

@0xc0170 requested changes on this pull request.

Uh oh!

0xc0170 commented Nov 29, 2016

Uh oh!

TsungtaWu commented Nov 29, 2016 via email

Uh oh!

0xc0170 Dec 2, 2016

Uh oh!

0xc0170 Dec 2, 2016

Uh oh!

0xc0170 commented Dec 2, 2016

Uh oh!

TsungtaWu commented Dec 2, 2016 via email

Uh oh!

TsungtaWu commented Dec 3, 2016 via email

Uh oh!

0xc0170 commented Dec 5, 2016

Uh oh!

mbed-bot commented Dec 5, 2016

Uh oh!

adbridge commented Dec 19, 2016

Uh oh!

Uh oh!

		@@ -0,0 +1,21 @@
		/* mbed Microcontroller Library
		* Copyright (c) 2006-2013 ARM Limited

DELTA_DFBM_NQ620 default configuration #3298

DELTA_DFBM_NQ620 default configuration #3298

Uh oh!

Conversation

TsungtaWu commented Nov 19, 2016

Uh oh!

0xc0170 Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

TsungtaWu commented Nov 21, 2016

@0xc0170 requested changes on this pull request.

Uh oh!

0xc0170 commented Nov 29, 2016

Uh oh!

TsungtaWu commented Nov 29, 2016 via email

Uh oh!

0xc0170 Dec 2, 2016

Choose a reason for hiding this comment

Uh oh!

0xc0170 Dec 2, 2016

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Dec 2, 2016

Uh oh!

TsungtaWu commented Dec 2, 2016 via email

Uh oh!

TsungtaWu commented Dec 3, 2016 via email

Uh oh!

0xc0170 commented Dec 5, 2016

Uh oh!

mbed-bot commented Dec 5, 2016

Result: SUCCESS

Output

Uh oh!

adbridge commented Dec 19, 2016

Uh oh!

Uh oh!