Skip to content

[Exporters] Fix generic ARM CPU target in uvision #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2016

Conversation

sarahmarshy
Copy link
Contributor

@sarahmarshy sarahmarshy commented Dec 1, 2016

When a target does not have a device name, we want to use a generic ARM cpu export target. This fixes a bug in the implementation of that functionality.

Reproduce:
Run mbed export on a target without a device name. It should not fail, as the intended logic was for this line to find a generic CPU target. However, as it is, it will fail.

@theotherjimmy

Generic CPU target not found correctly, because it was not accessing the Cache's index.

@theotherjimmy
@sarahmarshy
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Dec 1, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 37

All exports and builds passed!

@bridadan
Copy link
Contributor

bridadan commented Dec 1, 2016

@sarahmarshy If it wasn't accessing the cache's index, which index was it accessing? Could you explain the different indexes a bit?

@sarahmarshy
Copy link
Contributor Author

sarahmarshy commented Dec 1, 2016

It wasn't accessing anything. That variable doesn't exist. It threw an exception. Additionally, this is a static method, so really the only thing it can access are other static variables (cache being the only one).

@bridadan
Copy link
Contributor

bridadan commented Dec 1, 2016

Ah I see, when did this exception occur? The exporter tests have been working for sometime now. Is this only when building up a new index?

@sarahmarshy
Copy link
Contributor Author

sarahmarshy commented Dec 1, 2016

When determining support. All the targets that threw this exception would be considered "skipped."

@bridadan
Copy link
Contributor

bridadan commented Dec 1, 2016

Great, thanks for the clarification @sarahmarshy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants