[make exporters] Adding quotes to echo statements #3415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue when make is ran inside the Windows command prompt
|
/morph export-build |
theotherjimmy
approved these changes
Dec 9, 2016
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 51 Exporter Build failed! |
|
Tests should be fixed when #3416 is merged |
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 60 All exports and builds passed! |
|
For clarification, this was only an issue when exported make projects were compiled from the Windows Command Prompt. It is not a problem when ran inside a bash shell on Windows. Since the CI does this, it was not detected as a failure (hence why the exporter tests haven't been failing on all the other PRs). Should be ready to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason, make has issues issuing an
echocommand that doesn't use quotes when ran inside the Windows command prompt (not in bash). This PR adds quotes to the problematicechocommands.Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Todos