Change slave address in I2C master slave asynch test #3428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change test slave address to 0x80 because 0x90 is used by a real slave (temperature sensor) on few boards like the CI shield.
|
Any strong opinions @0xc0170? Nothing in our CI systems currently touch this test. |
0xc0170
approved these changes
Dec 13, 2016
|
retest uvisor |
1 similar comment
|
retest uvisor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0x90 is I2C slave device address which is used on by temperature sensor (like TMP102 temperature sensor, also on ci test shiled). So to avoid conflicts on a board where the sensor is used and we also want to test master / slave communication, I propose to change the default salve address to another one (if 0x80 is not suitable, feel free to propose another one)