STORAGE: FAT32/SDCARD Filesystem support with basic test (basic.cpp) #3468

simonqhughes · 2016-12-19T17:21:27Z

Description

This pull request contains the following changes:

The FAT32/SD card support has been moved from<src_root>\mbed-os\features\unsupported\fs to <src_root>\mbed-os\features\filesystem. This tree contains the fat and sd directories for the FATFileSystem and SDFileSystem support respectively.
The creation of tests under <src_root>\mbed-os\features\TESTS\filesystem
The addition the <src_root>\mbed-os\features\TESTS\filesystem\basic\basic.cpp test. This includes greentea ported tests from the glibc library.
The addition the <src_root>\mbed-os\features\TESTS\filesystem\fopen\fopen.cpp test. This includes ported tests from the CFSTORE open test.

The work is being delivered to the feature-storage branch for the Israel/mbed-client team to adopt.

Status

READY

Migrations

This PR does not change any APIs.

Related PRs

There are no related PRs.

theotherjimmy · 2016-12-19T20:39:52Z

@simonqhughes The Block Device API (introduced here #3449) will decouple the FAT FS from the SD Card driver. Please be aware of the changes that my need to occur depending on merging order of these two pull requests.

theotherjimmy · 2016-12-19T20:54:01Z

@simonqhughes Another note. ~~Please take a look at the Travis CI failure.~~ It looks to me like moving the FAT FS headers has messed with the USB code, which expected to be able to include it.

~~REDACTION: I don't think we care too much about that Travis failure for feature branches.~~

Well, now I care

sg- · 2016-12-19T23:40:57Z

REDACTION: I don't think we care too much about that Travis failure for feature branches.

Feature branches are deliverables and must pass all CI

sg- · 2016-12-19T23:42:08Z

Notes:

should live in features/filesystem
SD driver to move out of OS (i think) when block storage development is complete

geky · 2016-12-19T23:52:02Z

@theotherjimmy, I can retarget #3449 at the feature-storage branch. We should probably go ahead and merge this first, #3449 should be easy to rebase onto this since there should be no changes to the filesystem API. Additionally we get the sanity of running the glib tests @simonqhughes is bringing in on the pr.

geky · 2016-12-20T00:32:31Z

I don't know how long we want to keep build_travis in the tests for mbed-os. It seems like they may become more trouble then they are worth.

@simonqhughes, for now, here is the patch to redirect the build_travis step:
geky@6f88739#diff-178bb26296e93523919bbd312ce1de61

I wasn't sure if I could add that change to this pr, I didn't try in case it would mess up your development setup.

0xc0170 · 2016-12-20T15:56:24Z

I don't know how long we want to keep build_travis in the tests for mbed-os. It seems like they may become more trouble then they are worth.

It's not just about travis but about having some dependencies on this filesystem in the mbed 2 (scripts that are used for building mbed 2 libraries). Travis shows it nicely that there are some. How shall we fix this?

geky · 2016-12-20T16:19:19Z

@0xc0170, are these changes reasonable?
geky@6f88739#diff-178bb26296e93523919bbd312ce1de61

simonqhughes · 2016-12-20T17:51:27Z

Summary of changes:

The FAT32/SD card support has been moved from<src_root>\mbed-os\features\unsupported\fs to <src_root>\mbed-os\features\filesystem.
The creation of tests under <src_root>\mbed-os\features\TESTS\filesystem
The addition the <src_root>\mbed-os\features\TESTS\filesystem\basic\basic.cpp test. This includes greentea ported tests from the glibc library.
The addition the <src_root>\mbed-os\features\TESTS\filesystem\fopen\fopen.cpp test. This includes ported tests from the CFSTORE open test.
the addition of the fix reported by geky here: geky@ 6f88739 #diff-178bb26296e93523919bbd312ce1de61
fix to tools/paths.py to fix buld_travis.py results.

theotherjimmy · 2016-12-20T18:03:17Z

@simonqhughes Thanks for the summary. What do the test actually test for?

geky · 2016-12-20T21:52:43Z

@bridadan any idea why the jenkins check is failing?

sg- · 2016-12-20T21:58:39Z

[K64F ARM] Build failures:
[K64F ARM]   * K64F::ARM::FEATURES-TESTS-FILESYSTEM-FOPEN
[K64F ARM]         Building project fopen (K64F, ARM)
[K64F ARM]         Scan: ARM
[K64F ARM]         Scan: FEATURE_LWIP
[K64F ARM]         Scan: FEATURE_STORAGE
[K64F ARM]         Scan: fopen
[K64F ARM]         Compile [100.0%]: fopen.cpp
[K64F ARM]         [Warning] mbed_config.h@25,0:  #47-D: incompatible redefinition of macro "UNITY_INCLUDE_CONFIG_H"
[K64F ARM]         [Error] fopen.cpp@37,0:  #5: cannot open source input file "sys/stat.h": No such file or directory
[K64F ARM]         
[K64F ARM] [mbed] ERROR: "python" returned error code 1.

geky · 2016-12-20T22:47:59Z

Ah, thanks @sg-, it looks like this is an actual test failure that will require looking into.

0xc0170 · 2016-12-21T14:57:38Z

/morph test-nightly

geky · 2016-12-21T16:41:41Z

Assuming tests pass, LGTM, once merged we can make more granular changes as needed.

mbed-bot · 2016-12-21T16:57:11Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1312

Build failed!

geky · 2016-12-21T20:05:23Z

/morph test-nightly

mbed-bot · 2016-12-21T20:20:10Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1314

Build failed!

0xc0170 · 2016-12-22T10:32:50Z

@simonqhughes THe only failure for the latest one is build for SARA_NBIOT_EVK, is that related? Error is [Error] SDFileSystem.h@84,0: #20: identifier "SPI" is undefined

…ient team.

…ure-storage branch.

… subdir, and fs-fat tests to features/TESTS.

… present.

…tem.

…build correctly for targets that dont have SPI interfaces.

sg- · 2016-12-22T14:30:29Z

Why is this merged without /morph test-nightly passing?

0xc0170 · 2016-12-22T14:38:34Z

Why is this merged without /morph test-nightly passing?

/morph test-nightly

mbed-bot · 2016-12-22T16:49:08Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly passing?

Output

mbed Build Number: 1319

Test failed!

mbed-bot · 2016-12-22T18:20:00Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly passing?

/morph test-nightly

Output

mbed Build Number: 1320

All builds and test passed!

geky added the scope: feature label Dec 19, 2016

geky requested review from theotherjimmy and geky December 19, 2016 23:56

geky mentioned this pull request Dec 19, 2016

storage: Add block device API #3449

Closed

theotherjimmy approved these changes Dec 20, 2016

View reviewed changes

0xc0170 added needs: work and removed needs: work labels Dec 21, 2016

0xc0170 added the needs: CI label Dec 21, 2016

geky approved these changes Dec 21, 2016

View reviewed changes

simonqhughes added 2 commits December 22, 2016 11:14

Re-instating the FAT32/SDCard support with POSIX File API for mbed-cl…

affdf60

…ient team.

Updated FAT32 readme file to switch to correct branch.

f0cd57a

simonqhughes added 8 commits December 22, 2016 11:14

Ported glibc POSIX file API test test_rdwr to greentea.

807b826

STORAGE: updated basic test case and README for moving work onto feat…

0c7bd36

…ure-storage branch.

First version of fopen test added.

1cc6f7f

minor edits to fopen test.

ceb9266

FILESYSTEM: moved FAT filesystem implemenation to features/filesystem…

ab63f5a

… subdir, and fs-fat tests to features/TESTS.

FILESYSTEM: renamed features/TESTS/fs-fat features/TESTS/filesystem.

0ccc6fc

Fix fopen test build error due to #include <sys/stat.h>, which is not…

b5b8f17

… present.

FILESYSTEM: fix KL25Z CI build failure but not instantiaing SDFileSys…

e256981

…tem.

simonqhughes force-pushed the feature-storage branch from 970d9af to 3a0a3b6 Compare December 22, 2016 11:19

FILESYSTEM: Fix to only build SDFileSystem if DEVICE_SPI defined, to …

d8bf533

…build correctly for targets that dont have SPI interfaces.

simonqhughes force-pushed the feature-storage branch from 3a0a3b6 to d8bf533 Compare December 22, 2016 12:03

0xc0170 merged commit 80a74c6 into ARMmbed:feature-storage Dec 22, 2016

0xc0170 removed the needs: CI label Dec 22, 2016

STORAGE: FAT32/SDCARD Filesystem support with basic test (basic.cpp) #3468

STORAGE: FAT32/SDCARD Filesystem support with basic test (basic.cpp) #3468

Uh oh!

Conversation

simonqhughes commented Dec 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Migrations

Related PRs

Uh oh!

theotherjimmy commented Dec 19, 2016

Uh oh!

theotherjimmy commented Dec 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sg- commented Dec 19, 2016

Uh oh!

sg- commented Dec 19, 2016

Uh oh!

geky commented Dec 19, 2016

Uh oh!

geky commented Dec 20, 2016

Uh oh!

0xc0170 commented Dec 20, 2016

Uh oh!

geky commented Dec 20, 2016

Uh oh!

simonqhughes commented Dec 20, 2016

Uh oh!

theotherjimmy commented Dec 20, 2016

Uh oh!

geky commented Dec 20, 2016

Uh oh!

sg- commented Dec 20, 2016

Uh oh!

geky commented Dec 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Dec 21, 2016

Uh oh!

geky commented Dec 21, 2016

Uh oh!

mbed-bot commented Dec 21, 2016

Result: FAILURE

Output

Uh oh!

geky commented Dec 21, 2016

Uh oh!

mbed-bot commented Dec 21, 2016

Result: FAILURE

Output

Uh oh!

0xc0170 commented Dec 22, 2016

Uh oh!

sg- commented Dec 22, 2016

Uh oh!

0xc0170 commented Dec 22, 2016

Uh oh!

mbed-bot commented Dec 22, 2016

Result: FAILURE

Output

Uh oh!

mbed-bot commented Dec 22, 2016

Result: SUCCESS

Output

Uh oh!

Uh oh!

simonqhughes commented Dec 19, 2016 •

edited

Loading

theotherjimmy commented Dec 19, 2016 •

edited

Loading

geky commented Dec 20, 2016 •

edited

Loading