Remove invalid thread::start example #3469
Conversation
This changes reflects the correct syntax for spawning a thread that will execute a local function with given parameters.
|
just in case /morph test |
| @@ -54,7 +54,7 @@ namespace rtos { | |||
| * | |||
| * // Spawns a thread to run blink for 5 seconds | |||
| * int main() { | |||
| * thread.start(led1, blink); | |||
| * thread.start(callback(blink, &led1)); | |||
| * Thread::wait(5000); | |||
There was a problem hiding this comment.
mind getting rid of the Thread:: while you're in here too?
There was a problem hiding this comment.
Note, should be wait_ms(5000) (or wait(5)).
Also line 51
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@sg- donezo! |
|
So many check marks! But why is CI failing? |
|
@VeliMattiLahtela The Oulu CI is failing on this PR, however this is just a documentation change. Is this a problem that is in mbed-os master right now or is this just a problem with the mbed-os-cliapp tests? |
|
@bridadan The scaling of our testlab has resulted on a "few" intermittent errors becoming a little more frequent. Corrective actions are ongoing, but in the meantime these issues are unavoidable. For now we can only run them again and hope for the best. Failing cases are inspected on a daily basis and re-executed if a known error causing a false fail is seen. |
|
@VeliMattiLahtela Can we make it green please? |
|
All green now. We just got some changes in a couple of hours ago that should help quite a bit. |
Thank you |
|
Thanks for the support @VeliMattiLahtela and @tommikas! |
Description
This change reflects the correct syntax for spawning a thread that will execute a local function with given parameters.
The currently provided example will not compile. Inspired by #3396.
@geky @0xc0170
Status
READY
Steps to test or reproduce
Try to compile the currently provided example to view failure.