lwip - Fix static IP address issues with IPv4 #3526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @YixiaoLi for noting this was incorrect
Generalized handling of dns servers when brought up with both ipv4 and ipv6 addresses. Falls back to google dns servers if not dns server is found through dhcp. Also added support for the `add_dns_server` method to lwip to support custom servers.
geky
changed the title
|
👏 |
|
cc @kjbracey-arm @c1728p9 |
|
Sorry about the slipped message initially 😆 |
This was referenced Jan 4, 2017
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
kjbracey
approved these changes
Jan 5, 2017
There was a problem hiding this comment.
Looks okay to me, but I'd like @mikaleppanen to have a look.
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few lingering issues with static IPv4 addresses that was preventing the
set_networkfunction from working with lwip.Generalized handling of dns servers when brought up with both ipv4 and ipv6 addresses. Falls back to google dns servers if not dns server is found through dhcp.
Also added support for the
add_dns_servermethod to lwip to support custom servers.should resolve #3234
should resolve #3524
cc @kjbracey-arm