Allow user overrides of LINKER_SCRIPT Make variable #3594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, I take it that |
theotherjimmy
suggested changes
Jan 17, 2017
| LINKER_SCRIPT := {{linker_script}} | ||
| endif |
There was a problem hiding this comment.
Let's not reinvent the wheel here. this whole block is equal to
LINKER_SCRIPT ?= {{linker_script}}
|
Changed to use the conditional variable assignment operator. |
theotherjimmy
approved these changes
Jan 17, 2017
|
Removed. Fine by me, it's pretty clear what the change does. |
|
@nuket That's great! What a small diff. |
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 87 All exports and builds passed! |
0xc0170
approved these changes
Jan 19, 2017
|
Could we rebase-squash this series when we merge it? I'd rather see the single character change as one commit. |
simonqhughes
pushed a commit
to simonqhughes/mbed-os-1
that referenced
this pull request
Jan 31, 2017
Makefile: Allow user overrides of LINKER_SCRIPT Make variable
simonqhughes
pushed a commit
that referenced
this pull request
Jan 31, 2017
Makefile: Allow user overrides of LINKER_SCRIPT Make variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
LINKER_SCRIPToverrides via:The user can then set aside a block of flash memory for production config data by customizing the linker script like so: https://vilimpoc.org/blog/2016/12/25/flash-based-configuration-data-using-the-ld-linker/