Skip to content

Clean export dir #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 26, 2017
Merged

Clean export dir #3601

merged 9 commits into from
Jan 26, 2017

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Jan 17, 2017

Description

The export dir was a mess, so I cleaned it up

Status

READY

Todos

  • Tests - /morph export-build

@bridadan
Copy link
Contributor

@theotherjimmy Can you take a look at Travis?

@bridadan
Copy link
Contributor

bridadan commented Jan 17, 2017

@stevew817 @sg- It looks like @theotherjimmy has renamed simplicityv3 to simplicty, which I agree is definitely nicer to type. Is this a valid change from your end?

Also @theotherjimmy, it'd probably be best to alias siplicityv3 to simplicity first and show a DEPRECATION warning stating to use simplicity instead since this is a breaking change.

EDIT: Oops, nevermind!

@theotherjimmy
Copy link
Contributor Author

@bridadan The exporter is still named simplicityv3 I just put the exporter in the simplicity folder.

@bridadan
Copy link
Contributor

AH duh, thanks!

@stevew817
Copy link
Contributor

@bridadan We'll have to look at bringing our exporter up-to-date since we have moved from Simplicity Studio v3 to v4 (which doesn't break the format completely, but we'd like to update for anyway).

@stevew817
Copy link
Contributor

In other words: thanks for the reminder :)

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Jan 17, 2017

Hi @stevew817! We recently updated our export system so that the same options that we use within the tools are available to the exporters. I tried to update Simplicity v3's exporter within that change set, but it may not have been perfect. What I am trying to say is: An update is very welcome.

@theotherjimmy
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 90

All exports and builds passed!

@bridadan
Copy link
Contributor

@VeliMattiLahtela Looks like Oulu CI is having difficulty. I've restarted this one a few times and so far no luck. Any suggestions?

@tommikas
Copy link
Contributor

@bridadan Yesterday's updates to mbed-client broke both mbed-os-cliapp and mbed-client-testapp builds. Both are working again so I restarted the jobs that failed because of it.

@theotherjimmy
Copy link
Contributor Author

Thanks @tommikas !

@bridadan
Copy link
Contributor

Thanks again @tommikas! Really appreciate the support 😄

@tommikas
Copy link
Contributor

Happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants