-
Notifications
You must be signed in to change notification settings - Fork 3k
Memap detailed function also for mbed os modules #3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memap detailed function also for mbed os modules #3627
Conversation
retest uvisor |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
retest uvisor |
retest uvisor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to test with windows and a POSIX like os.
@javier-moreno-tridonic-com How was this tested (look at @theotherjimmy's comment above) |
@0xc0170 Unfortunately I can only test in on windows 7. The POSIX like testing part is missing |
Thanks for letting is know. If you could post what you expect the output to look like, I can test on a Linux box. |
@theotherjimmy Sure! This is the expected output:
|
This brings up another point: have you tested with IAR EWARM and ARMC5? (I'm working on testing now) |
No, unfortunately my current environment is only set for GCC_ARM |
Okay. I can't do that this week, but I can test with both of them from linux Tuesday. |
Great, thanks :) |
looks good for linux + gcc:
|
Nit: the commit message should describe what's the update about. The rest is LGTM |
@javier-moreno-tridonic-com Needs testing with IAR and ARM before coming in. @theotherjimmy who is going to verify these? |
Ah, whoops. I'll test with ARM and IAR on linux right away. |
Looking good for ARM+Linux:
|
Linux + IAR looks good:
Shhhh.... don't tell me this was silly |
@bridadan any concerns for CI etc? Otherwise its coming in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sg- build stat results look ok still so fine with me!
Notes:
Description
With this change the detailed option can also be applied to mbed os modules
Status
READY