[Exporters] Add core to uvision exporter template #3661
Conversation
|
/morph export-build |
|
@michaelVisimid Could you review if you get the chance? |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 97 Exporter Build failed! |
|
It mostly worked! The problem is it doesn't seem to work for Cortex-M7 targets. |
|
I would suspect that was why it was removed in the first place. To clarify when using the out of date exporter from the mbed online compiler it generates this line:
|
|
I suspect is because M7F is not correct (looking at the failures). It should help if we strip F. I checked, if you choose M4 with floating point, CPU is M4, fpu is a separate setting, and in this case for M7 it would be dp vs sp. |
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 99 Exporter Build failed! |
|
Whoops my bad |
theotherjimmy
force-pushed
the
uvision-add-cpu
branch
from
cf56944 to
524952e
Compare
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 100 Exporter Build failed! |
|
Now for double floats. I'm going to squash in the process. no need for 3 commits for ~5 lines changed. |
theotherjimmy
force-pushed
the
uvision-add-cpu
branch
2 times, most recently
from
d1107e4 to
9c87b31
Compare
Strip trailing F's and D's off of the Cputype in uvision
theotherjimmy
force-pushed
the
uvision-add-cpu
branch
from
9c87b31 to
eadbe71
Compare
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 101 All exports and builds passed! |
There was a problem hiding this comment.
LGTM. Should we use it for this section as well? https://github.com/ARMmbed/mbed-os/blob/master/tools/export/uvision/uvision.tmpl#L216. Yours is a more transparent solution.
|
@sarahmarshy What does transparent mean in this context? |
|
@theotherjimmy Logic is not hidden in the template file. |
Add the correct output to the Core tag of Target Options within the
Uvision project file template
READY
ARMmbed/mbed-cli#427