Enable boot-loader builds #3733

theotherjimmy · 2017-02-09T21:04:02Z

To enable a boot-loader style application, overrides
"targets.bootloader_exec" or "targets.restrict_size" on a particular
target. These parameters are a bin or hex file and an integer, in bytes,
respectively. If either override is present, then an application region
is created after the boot-loader region, when "targets.bootloader_exec"
is present, and before post-application, when "targets.restric_size" is
present. The size of the boot-loader region is read from the file
provided in the configuration.

Status

READY

Todos

Tests - standard stuff

theotherjimmy · 2017-02-09T21:04:41Z

/morph test

mbed-bot · 2017-02-09T21:35:58Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1550

Test Prep failed!

theotherjimmy · 2017-02-09T21:43:35Z

test prep failed !? :/

ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.

Looks like my rebasing killed it.

/morph test

c1728p9 · 2017-02-09T22:24:11Z

tools/build_api.py

+            part = IntelHex()
+            _, inteltype = splitext(region.filename)
+            part.fromfile(region.filename, inteltype[1:])
+            if part.maxaddr() > region.size:


Should this be ">=" rather than ">"?

c1728p9 · 2017-02-09T22:27:55Z

tools/build_api.py

+            pad_size = region.size - (part.maxaddr() + 1)
+            if pad_size > 0 and region != region_list[-1]:
+                print("  Padding region %s with %d bytes" % (region.name, pad_size))
+                merged.puts(region.start + part.maxaddr(),


Is this going to clobber the last byte of region?

Nope. The size should be calculated correctly as pad_size above

c1728p9 · 2017-02-09T22:28:26Z

tools/build_api.py

+
+    if not exists(dirname(destination)):
+        makedirs(dirname(destination))
+    print("Space used after regions merged: %d" % merged.maxaddr())


Should one be added here?

c1728p9 · 2017-02-09T22:36:39Z

tools/config.py

+            _, inteltype = splitext(filename)
+            ih = IntelHex()
+            ih.fromfile(filename, format=inteltype[1:])
+            if ih.minaddr() != 0:


I just realized that the STMF429 has flash starting at address 0x08000000 so non-zero flash address support will be needed.

Okay. Thanks.

mbed-bot · 2017-02-10T00:33:32Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1552

All builds and test passed!

theotherjimmy · 2017-02-10T17:00:27Z

Just rebased to address @c1728p9's comments. It's good to run testing again.

/morph test

c1728p9 · 2017-02-10T17:28:31Z

tools/config.py

+            _, inteltype = splitext(filename)
+            ih = IntelHex()
+            ih.fromfile(filename, format=inteltype[1:])
+            if ih.minaddr() != 0 and ih.minaddr() != rom_start:


Why is this still checked against address 0?

In the case of .bin files, there is no specified start address, so it defaults to zero.

mbed-bot · 2017-02-10T17:46:50Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

theotherjimmy · 2017-02-10T19:44:32Z

Rebased master so that travis will pass.

/morph test

c1728p9 · 2017-02-10T20:16:26Z

tools/build_api.py

+
+    if not exists(dirname(destination)):
+        makedirs(dirname(destination))
+    print("Space used after regions merged: 0x%x" % (merged.maxaddr() + 1))


This is printing the max address rather than size

c1728p9 · 2017-02-10T20:18:55Z

tools/build_api.py

+                       (region.name.upper() + "_SIZE", region.size)]:
+            profile["common"].append("-D%s=0x%x" %  define)
+    active_region = [r for r in regions if r.active][0]
+    for define in [("MBED_APP_OFFSET", active_region.start),


Since this is an absolute address it might make more sense as "MBED_APP_START"

You're right.

c1728p9 · 2017-02-10T20:21:24Z

tools/config.py

+            part = intelhex_offset(filename, offset=rom_start)
+            if part.minaddr() != rom_start:
+                raise ConfigException("bootloader executable does not "
+                                      "start at 0")


This message should be updated to use the new address

Yes it should.

c1728p9 · 2017-02-10T20:22:18Z

tools/utils.py

+    if inteltype == ".bin":
+        ih.loadbin(filename, offset=offset)
+    elif inteltype == ".hex":
+        ih.loadhex(filename)


Might want to raise an exception here indicating that the filetype is unsupported.

I will do that.

It now does that.

mbed-bot · 2017-02-10T21:00:41Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1560

Test Prep failed!

theotherjimmy · 2017-02-10T21:39:49Z

looks like another rebase killed the bot.

/morph test

mbed-bot · 2017-02-10T22:36:45Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1561

All builds and test passed!

theotherjimmy · 2017-02-17T15:43:55Z

/morph test

sg-

Can you add a second commit that adds a flag bootload-supportto the target class which represents that the linker scripts have been modified to support multiple execution regions in a flat memory space

bootloader_exec can this be binary or hex or both? If only one maybe bootloader_bin or bootloader_hex otherwise just bootloader_img if can handle both

mbed-bot · 2017-02-17T19:11:21Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1628

All builds and test passed!

bridadan · 2017-02-19T16:25:34Z

retest uvisor

0xc0170 · 2017-02-20T15:15:20Z

@theotherjimmy Can you please review the @sg- comment above?

theotherjimmy · 2017-02-21T18:41:48Z

@sg- This has been updated to reflect your comment.

theotherjimmy · 2017-02-21T21:03:28Z

@sg- What do you want from the bootloader_support flag? are you expecting it to be a flag it targets.json? Would it be top level or part of device_has?

To enable a boot-loader style application, override "targets.bootloader_exec" or "targets.restrict_size" on a particular target. These parameters are a bin or hex file, and an integer, in bytes, respectively. If either override is present, then an application region is created after the boot-loader region, when "targets.bootloader_exec" is present, and before post-application, when "targets.restric_size" is present. The size of the boot-loader region is read from the file provided in the configuration.

This patch will prevent building bootloader builds on targets that have not yet had their linker scripts/scatter files changed to allow for the ROM space shrinking expected by bootloader builds. At the point of this patch, bootloader linker script modifications are only supported by the NUCLEO_F429ZI, K64F, KL46Z, and Odin.

theotherjimmy · 2017-02-23T00:32:34Z

Lolwut? did not mean to do that. Might have been a stray return

/morph test

mbed-bot · 2017-02-23T04:03:12Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1683

All builds and test passed!

theotherjimmy requested review from c1728p9 and 0xc0170 February 9, 2017 21:04

theotherjimmy force-pushed the feature-bootloader branch 8 times, most recently from 2887a7d to 956d9b9 Compare February 9, 2017 21:26

c1728p9 reviewed Feb 9, 2017

View reviewed changes

theotherjimmy force-pushed the feature-bootloader branch from 956d9b9 to e604eaf Compare February 10, 2017 16:59

theotherjimmy force-pushed the feature-bootloader branch from e604eaf to d8b54ef Compare February 10, 2017 17:02

c1728p9 reviewed Feb 10, 2017

View reviewed changes

theotherjimmy force-pushed the feature-bootloader branch 4 times, most recently from 0033855 to 3025fd3 Compare February 10, 2017 19:42

c1728p9 reviewed Feb 10, 2017

View reviewed changes

theotherjimmy force-pushed the feature-bootloader branch from 3025fd3 to 3b1c1b6 Compare February 10, 2017 20:27

theotherjimmy force-pushed the feature-bootloader branch from bf6117d to 3e15542 Compare February 17, 2017 15:43

sg- suggested changes Feb 17, 2017

View reviewed changes

0xc0170 added needs: work and removed needs: CI labels Feb 20, 2017

theotherjimmy force-pushed the feature-bootloader branch from 3e15542 to 319647d Compare February 21, 2017 17:13

0xc0170 added ready for merge and removed needs: work labels Feb 21, 2017

0xc0170 added needs: work and removed ready for merge labels Feb 22, 2017

c1728p9 added the release-version: 5.4.0 label Feb 22, 2017

theotherjimmy added 2 commits February 22, 2017 18:20

theotherjimmy closed this Feb 23, 2017

theotherjimmy force-pushed the feature-bootloader branch from 319647d to d62f046 Compare February 23, 2017 00:30

theotherjimmy reopened this Feb 23, 2017

sg- added needs: CI and removed needs: work labels Feb 23, 2017

sg- approved these changes Feb 23, 2017

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Feb 23, 2017

sg- merged commit ba21763 into ARMmbed:master Feb 23, 2017

sg- removed the ready for merge label Feb 23, 2017

Enable boot-loader builds #3733

Enable boot-loader builds #3733

Uh oh!

Conversation

theotherjimmy commented Feb 9, 2017

Status

Todos

Uh oh!

theotherjimmy commented Feb 9, 2017

Uh oh!

mbed-bot commented Feb 9, 2017

Output

Uh oh!

theotherjimmy commented Feb 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-bot commented Feb 10, 2017

Output

Uh oh!

theotherjimmy commented Feb 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-bot commented Feb 10, 2017

Uh oh!

theotherjimmy commented Feb 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-bot commented Feb 10, 2017

Output

Uh oh!

theotherjimmy commented Feb 10, 2017

Uh oh!

mbed-bot commented Feb 10, 2017

Output

Uh oh!

theotherjimmy commented Feb 17, 2017

Uh oh!

sg- left a comment

Choose a reason for hiding this comment

Uh oh!

mbed-bot commented Feb 17, 2017

Output

Uh oh!

theotherjimmy commented Feb 21, 2017 •

edited

Loading