STM32 RTC api minor update #3743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer we add a unified debug method before taking this. Sure there are examples where this exists but I'd suggest we dont take more, rather, start a common implementation. |
|
Needs rebase, to make travis green |
Add more detailed information in comments Issue with sunday corrected Issue with wrong rtc_isenabled status corrected
jeromecoutant
force-pushed
the
PR_RTC_UPDATE
branch
from
7f9e0d6 to
3a83fc8
Compare
|
Debug messages have been removed, and rebase done. |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
fixes #3668 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add debug capability
Add more detailed information in comments
Issue with sunday corrected
Issue with wrong rtc_isenabled status corrected (#3668)
Status
READY