Add a function to transfer control to another app #3748

c1728p9 · 2017-02-11T00:27:31Z

Add the function mbed_application_start() which allows a bootloader to transfer control to an application.

c1728p9 · 2017-02-11T00:32:00Z

CC: @LiyouZhou

c1728p9 · 2017-02-11T00:32:04Z

/morph test

mbed-bot · 2017-02-11T00:59:31Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1564

Build failed!

sg-

A few nits. Looks quite good but will need some strong worded docs about assumptions made when transferring control regarding systick, scb and nvic

sg- · 2017-02-13T16:24:15Z

platform/mbed_application.h

+
+#include<stdint.h>
+
+#define MBED_APPLICATION_SUPPORT (defined(__CORTEX_M3) || defined(__CORTEX_M4) || defined(__CORTEX_M7))


What will be different in M0 and can it be added now?

On the M0 the VTOR is optional. Devices that have a VTOR could be supported easily, but I'm not sure if there is a good way to tell that. Alternatively, for M0 the reset sequence could be to jump to the reset handler and leave it up to the application to remap interrupts as necessary.

sg- · 2017-02-13T16:25:37Z

platform/mbed_application.h

+#endif
+
+/**
+ *  Start the application at the given address. This function does


all documentation reads '... start application ...' but the function name is application_start. Just difficult to read. Should the func be mbed_start_application(addr);

I'll rename so it makes more sense to users. The function was named like this so the prefix matched the filename, similar to mbed_stats_heap_get.

sg- · 2017-02-13T16:26:11Z

platform/mbed_application.c

+    BX R1
+}
+
+#elif defined (__GNUC__)


Can the IAR and GNU implementation be unified? What about ARM compiler?

ARMCC has its own syntax so it can't be unified. As is the GCC and IAR function can be unified, but I'm not sure if this is a good idea. I don't know how much of the syntax is different between these two assemblers.

c1728p9 · 2017-02-13T23:56:49Z

/morph test

0xc0170 · 2017-02-14T14:36:28Z

platform/mbed_application.c

+    void *pc;
+
+    // Interrupts are re-enabled in start_new_application
+    core_util_critical_section_enter();


is there anywhere exit called? I can see interrupts are enabled in the asm functions below. I am asking as critical sections can be nested (contain counters), thus this would lead that there's currently still one active critical section?

There is no call to critical section exit, instead right before jumping to the next application, interrupts are re-enabled with "msr primask, r2" where r2=0.

yes, but that is incorrect, every enter should have counterpart exit?

bridadan · 2017-02-14T18:28:06Z

/morph test

mbed-bot · 2017-02-14T22:33:04Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1594

All builds and test passed!

c1728p9 · 2017-02-14T23:32:13Z

Updated PR to replace core_util_critical_section_enter with __disable_irq, add parameter and clobber list in start_new_application and combine GCC and IAR assembly.

c1728p9 · 2017-02-14T23:32:17Z

/morph test

mbed-bot · 2017-02-15T00:28:37Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1595

All builds and test passed!

sg-

One last nit, sorry :(

sg- · 2017-02-17T15:23:15Z

platform/mbed_application.c

+
+void mbed_start_application(uintptr_t address)
+{
+


sg- · 2017-02-17T15:29:02Z

/morph test

mbed-bot · 2017-02-17T18:31:46Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1627

All builds and test passed!

Add the function mbed_start_application() which allows a bootloader to transfer control to an application.

c1728p9 · 2017-02-19T01:49:10Z

rebased the PR in the hopes it will restart the Cam-CI

c1728p9 · 2017-02-19T01:49:14Z

/morph test

bridadan · 2017-02-19T16:29:00Z

/morph test

mbed-bot · 2017-02-19T22:19:42Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1651

All builds and test passed!

c1728p9 force-pushed the application_transfer_support branch from 5bc7425 to ae5be6d Compare February 11, 2017 00:28

c1728p9 requested review from theotherjimmy and 0xc0170 February 11, 2017 00:31

sg- suggested changes Feb 13, 2017

View reviewed changes

sg- added the needs: review label Feb 13, 2017

c1728p9 force-pushed the application_transfer_support branch from ae5be6d to 35ec0cd Compare February 13, 2017 23:56

0xc0170 reviewed Feb 14, 2017

View reviewed changes

c1728p9 force-pushed the application_transfer_support branch from 35ec0cd to 7047d0f Compare February 14, 2017 23:30

0xc0170 approved these changes Feb 15, 2017

View reviewed changes

theotherjimmy approved these changes Feb 15, 2017

View reviewed changes

c1728p9 added the release-version: 5.4.0 label Feb 16, 2017

sg- suggested changes Feb 17, 2017

View reviewed changes

platform/mbed_application.c Outdated

void mbed_start_application(uintptr_t address)

{

Copy link

Contributor

sg- Feb 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra /n

c1728p9 force-pushed the application_transfer_support branch from 7047d0f to 590fff4 Compare February 17, 2017 15:28

sg- approved these changes Feb 17, 2017

View reviewed changes

Add a function to transfer control to another app

36cbae6

Add the function mbed_start_application() which allows a bootloader to transfer control to an application.

c1728p9 force-pushed the application_transfer_support branch from 590fff4 to 36cbae6 Compare February 19, 2017 01:48

bridadan added the needs: CI label Feb 19, 2017

0xc0170 added ready for merge and removed needs: CI needs: review ready for merge labels Feb 20, 2017

0xc0170 merged commit 4470d04 into ARMmbed:master Feb 21, 2017


		#include<stdint.h>

		#define MBED_APPLICATION_SUPPORT (defined(__CORTEX_M3) \|\| defined(__CORTEX_M4) \|\| defined(__CORTEX_M7))

Add a function to transfer control to another app #3748

Add a function to transfer control to another app #3748

Uh oh!

Conversation

c1728p9 commented Feb 11, 2017

Uh oh!

c1728p9 commented Feb 11, 2017

Uh oh!

c1728p9 commented Feb 11, 2017

Uh oh!

mbed-bot commented Feb 11, 2017

Output

Uh oh!

sg- left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c1728p9 commented Feb 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bridadan commented Feb 14, 2017

Uh oh!

mbed-bot commented Feb 14, 2017

Output

Uh oh!

c1728p9 commented Feb 14, 2017

Uh oh!

c1728p9 commented Feb 14, 2017

Uh oh!

mbed-bot commented Feb 15, 2017

Output

Uh oh!

sg- left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sg- commented Feb 17, 2017

Uh oh!

mbed-bot commented Feb 17, 2017

Output

Uh oh!

c1728p9 commented Feb 19, 2017

Uh oh!

c1728p9 commented Feb 19, 2017

Uh oh!

bridadan commented Feb 19, 2017

Uh oh!

mbed-bot commented Feb 19, 2017

Output

Uh oh!

Uh oh!