Skip to content

Improve readability of USBHID related descriptors #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Improve readability of USBHID related descriptors #3772

merged 1 commit into from
Feb 17, 2017

Conversation

Ingramz
Copy link
Contributor

@Ingramz Ingramz commented Feb 14, 2017

Description

While debugging for another issue, I made some formatting changes to existing code to better understand it myself.

  • Changed generic USBHID report descriptor to use predefined macros for descriptor field types/sizes which are already used in USBMouse and USBKeyboard. Compiled result is identical to previous code.
  • Tweaked configuration descriptor formatting so they can be more easily diffed
    • Defined the remaining HID sublasses and protocols to provide give context to magic values
    • Aligned comments
    • Cleaned up redundancies in comments

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

CLA has been signed https://developer.mbed.org/users/ingram/

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2017

How was this tested?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2017

/morph test

@Ingramz
Copy link
Contributor Author

Ingramz commented Feb 15, 2017

I ran the USBHID example on LPC1768 and read the report descriptors using software called USBlyzer.

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1599

All builds and test passed!

@sg- sg- merged commit 2a33114 into ARMmbed:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants