lwip: Added delay to dtls handshake test to compensate for local network #3781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridadan
reviewed
Feb 15, 2017
| @@ -42,6 +43,9 @@ def handle(self): | |||
| data = ''.join(map(chr, data)) | |||
| sock.sendto(data, self.client_address) | |||
|
|
|||
| # Sleep a tiny bit to compensate for local network | |||
| time.sleep(0.001) | |||
There was a problem hiding this comment.
I had to increase this to 0.01 on my machine for this to work
There was a problem hiding this comment.
Checked with @bridadan offline, looks like I had forgotten the MBED_STACK_STATS_ENABLED and MBED_HEAP_STATS_ENABLED, which cause increased delay on the device side.
The speed of packets on the local network exceeds even the speed of the ethernet hardware on some of the less powerful devices. Adding a small delay which can be expected from a real DTLS handshake prevents this condition from occuring.
geky
force-pushed
the
lwip-dtls-speed
branch
from
5410c0f to
64ccff3
Compare
|
Fixed the delay issue. As I understand there isn't a set delay in the DTLS specification, so it's basically up to the DTLS implementation to be nice to the slow devices. |
|
/morph test-nightly |
bridadan
approved these changes
Feb 15, 2017
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
sg-
added
release-version: 5.1.3
release-version: 5.4.0
and removed
ready for merge
release-version: 5.1.3
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The speed of packets on the local network exceeds even the speed of the ethernet hardware on some of the less powerful devices. Adding a small delay which can be expected from a real DTLS handshake prevents this condition from occuring.
Let me know if there is still problems with this test as this delay may need to be refined.
cc @bridadan, @MarceloSalazar
should resolve #3549