Separating CoAP library from mbed-client-c #3789
Conversation
This commit includes - Removing CoAP sources from mbed-client-c to its own repository. - mbed-client-c is moved outside of mbed-os source tree because it is used by mbed-client, so it will be part of mbed-client offering. - CoAP sources are used by coap-service which is a part of nanostack deliveries hence coap now existing as independent module under mbed-coap. - Commit handles the interdepdency of coap-service with mbed-client-c because of coap sources, coap-service header files are now fixed to point to right header directory.
|
@0xc0170 @sg- PR for mbed-os 5.4 Release Candidate. |
|
retest uvisor |
|
Hi @bridadan , any progress on this PR ? |
|
uVisor CI looks ok, had to restart the Oulu CI. Starting Austin CI now. /morph test-nightly |
|
@yogpan01 Issues found by Oulu CI: Building mbed-os-cliapp: https://jenkins-internal.mbed.com/job/ARMmbed/job/mbed-os-cliapp/job/master/2533/consoleFull#1008184494174b4c30-7b05-4bb6-8c92-7590427bafc4 Building mbed-client-testapp: https://jenkins-internal.mbed.com/job/ARMmbed/job/mbed-client-testapp/job/master/2946/consoleFull#2009826715174b4c30-7b05-4bb6-8c92-7590427bafc4 |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@yogpan01 Please keep us updated about the status of this patch. |
| @@ -0,0 +1,195 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
Pretty sure this file doesnt need to be in tree.
There was a problem hiding this comment.
That file is from the master repository, where it is intended to be present. Removing it would mean performing a transformation during import, which I assume is not otherwise happening?
I understood that imported code could generally be left as-is, relying on .mbedignore to filter out unwanted stuff from the build as necessary. Can that be the case here?
There was a problem hiding this comment.
Thanks for the clarification. I didn't realize its intended to be present in the development repo.
Done. Just the mbed-client-testapp failing now. |
|
@yogpan01 How is it looking today? |
|
@teetak01 is fixing the mbed-client-testapp compilation to adapt to this new source structure. Should be ready today. |
|
retest uvisor |
|
Client-CI fixed. Retriggered tests and Client-tests are already passed. |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
A python process spinning up for the test took longer than normal, causing a failed test. @geky is looking at it now. In the interest of getting as many PRs tested as possible, I killed this job immediately. I will restart it now to get it back into the queue. /morph test-nightly |
|
pr up to fix the test issue here: #3832 |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Description
This commit includes
it will be part of mbed-client offering.
as independent module under mbed-coap.
header files are now fixed to point to right header directory.
Status
READY
Migrations
NO
Related PRs
ARMmbed/mbed-client-c#125
PelionIoT/mbed-coap#1
PelionIoT/mbed-coap#2
PelionIoT/mbed-coap#3
PelionIoT/coap-service#62