Skip to content

Add NS_DUMMY_DEFINITIONS_OK #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Add NS_DUMMY_DEFINITIONS_OK #3830

merged 1 commit into from
Feb 23, 2017

Conversation

SeppoTakalo
Copy link
Contributor

Add definition from master repository.
This fixes compilation of coap_service.c on non-secure platforms.

Description

Currently, any application requiring FEATURE_NANOSTACK and FEATURE_COMMON_PAL fails to build.
Apparently when Coap-service was updated, it pulls in a code that uses macro NS_DUMMY_DEFINITIONS_OK that is in the master repository of libservice, but not on the version in mbed-OS tree.

Status

READY

Steps to test or reproduce

  1. Clone mbed-os-example-blinky
  2. Set target without HW entropy, like NUCLEO_F401RE
  3. Add features NANOSTACK and COMMON_PAL into mbed_app.json
    Fails to compile.

Add definition from master repository.
This fixes compilation of coap_service.c on non-secure platforms.
@SeppoTakalo
Copy link
Contributor Author

@0xc0170 @sg- We need this in quite quickly in order to be ready for 5.4 code freeze.

Apparently, we don't build Mesh examples to unsecure platforms, when verifying PRs.
This code that triggered the build error is after condition that when mbed TLS is not available.
Therefore it was not visible for most of our platforms.

@sg-
Copy link
Contributor

sg- commented Feb 23, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1692

All builds and test passed!

@sg- sg- merged commit e9880c7 into master Feb 23, 2017
@0xc0170 0xc0170 deleted the dummy_definitions branch June 21, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants