Skip to content

tools: add new examples #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2017
Merged

tools: add new examples #3888

merged 1 commit into from
Apr 20, 2017

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Mar 6, 2017

Bootloader, bootloader blinky and fat filesystem examples added.

Up for review, to bring examples json file up to date.

@c1728p9 @simonqhughes @adbridge - please review. check if the example supports the configuration that is in here. Let me know, I'll add it based on your inputs

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same two review questions on all 3 examples.

"name": "mbed-os-example-bootloader-blinky",
"github":"https://github.com/ARMmbed/mbed-os-example-bootloader-blinky",
"mbed": [
"https://developer.mbed.org/teams/mbed-os-examples/code/mbed-os-example-bootloader-blinky"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these new examples exist on mbed org yet ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think so, we will need to push them once it goes out.

"https://developer.mbed.org/teams/mbed-os-examples/code/mbed-os-example-bootloader-blinky"
],
"features" : [],
"targets" : ["DISCO_F469NI", "DISCO_F746NG", "K64F",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this example only works on those specified targets ?

Copy link
Contributor Author

@0xc0170 0xc0170 Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's limited. Current scope - needs to be checked. Waiting for @c1728p9 to update this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example only supports K64F, NUCLEO_F429ZI and UBLOX_EVK_ODIN_W2 currently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K64F, NUCLEO_F429ZI and UBLOX_EVK_ODIN_W2

I shall then update to these platforms

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 6, 2017

@AlessandroA Please review if all examples are there from uvisor point of view

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 6, 2017

@theotherjimmy - fat file system - please review

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 20, 2017

@adbridge will you replace this one as well? These examples should be updated !

@adbridge
Copy link
Contributor

That one is good to go once reviewed by Jimmy to ensure we actually are able to run those

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything to add, so just appease the other reviewers.

@AlessandroA
Copy link
Contributor

@0xc0170 :

@AlessandroA Please review if all examples are there from uvisor point of view

LGTM 👍

Bootloader, bootloader blinky and fat filesystem examples added.
@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 29, 2017

I updated this based on the feedback. @adbridge We need to publish this new examples and make a progress wtih this PR !

@adbridge
Copy link
Contributor

retest uvisor

@adbridge
Copy link
Contributor

@mazimkhan can you please check uvisor job, either I am unable to kick the job off or else it has broken

@mazimkhan
Copy link

It has passed. Don't know why status is not updated. Also no github errors.
http://e108747.cambridge.arm.com:8080/job/mbed-os/job/mbed-os-pr-uvisor-test-pipeline/2158/
I can re-run if you want.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 4, 2017

retest uvisor

@sg-
Copy link
Contributor

sg- commented Apr 10, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1869

Build failed!

@bridadan
Copy link
Contributor

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1882

Test failed!

@bridadan
Copy link
Contributor

Looks like a network failure for a NUCLEO board. Seeing this crop up a bit more often lately, will try to keep an eye on it...

/morph test-nightly

@bridadan
Copy link
Contributor

/morph test-nightly

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 26

All builds and test passed!

@bridadan
Copy link
Contributor

Marking as needs: review pending final review from @c1728p9.

@adbridge adbridge merged commit a1d1a60 into ARMmbed:master Apr 20, 2017
@0xc0170 0xc0170 deleted the fix_add_examples branch September 1, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants