-
Notifications
You must be signed in to change notification settings - Fork 3k
tools: add new examples #3888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add new examples #3888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same two review questions on all 3 examples.
tools/test/examples/examples.json
Outdated
"name": "mbed-os-example-bootloader-blinky", | ||
"github":"https://github.com/ARMmbed/mbed-os-example-bootloader-blinky", | ||
"mbed": [ | ||
"https://developer.mbed.org/teams/mbed-os-examples/code/mbed-os-example-bootloader-blinky" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these new examples exist on mbed org yet ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think so, we will need to push them once it goes out.
tools/test/examples/examples.json
Outdated
"https://developer.mbed.org/teams/mbed-os-examples/code/mbed-os-example-bootloader-blinky" | ||
], | ||
"features" : [], | ||
"targets" : ["DISCO_F469NI", "DISCO_F746NG", "K64F", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this example only works on those specified targets ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's limited. Current scope - needs to be checked. Waiting for @c1728p9 to update this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example only supports K64F, NUCLEO_F429ZI and UBLOX_EVK_ODIN_W2 currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K64F, NUCLEO_F429ZI and UBLOX_EVK_ODIN_W2
I shall then update to these platforms
@AlessandroA Please review if all examples are there from uvisor point of view |
@theotherjimmy - fat file system - please review |
@adbridge will you replace this one as well? These examples should be updated ! |
That one is good to go once reviewed by Jimmy to ensure we actually are able to run those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have anything to add, so just appease the other reviewers.
@0xc0170 :
LGTM 👍 |
Bootloader, bootloader blinky and fat filesystem examples added.
063d120
to
137e47f
Compare
I updated this based on the feedback. @adbridge We need to publish this new examples and make a progress wtih this PR ! |
retest uvisor |
@mazimkhan can you please check uvisor job, either I am unable to kick the job off or else it has broken |
It has passed. Don't know why status is not updated. Also no github errors. |
retest uvisor |
/morph test-nightly |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
Looks like a network failure for a NUCLEO board. Seeing this crop up a bit more often lately, will try to keep an eye on it... /morph test-nightly |
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Marking as |
Bootloader, bootloader blinky and fat filesystem examples added.
Up for review, to bring examples json file up to date.
@c1728p9 @simonqhughes @adbridge - please review. check if the example supports the configuration that is in here. Let me know, I'll add it based on your inputs