uVisor: Fix 'publish' and core libs dependencies #3906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'TARGET_M%' rules depend on files generated by the 'rsync' target, so make this dependency explicit by setting 'rsync' as a pre-requisite of 'TARGET_M%'. The 'rsync' dependency was removed from 'publish' to avoid the case where make would select one of the 'TARGET' rules before completing 'rsync', which would cause the build to fail. Additionally, also moved the core libs selection in the 'TARGET_M%' pattern rule from the pre-requisites into the rule's recipe. This is required because when the wildcard expression used before as a pre-requisite is expanded (make's 1st phase), it won't find any files (not built yet via 'rsync' target), so it won't create the associated 'TARGET_M%' rules, finally causing the 'publish' target building to fail due to missing rules for 'TARGET_M3' and 'TARGET_M4'. With this change and the previous one, it is ensured that 'rsync' is done before executing the recipe for 'TARGET_M%', so the required core libs are already available and can be used from withing the recipe. The same wildcard pattern is used as before. The issues being fixed are visible with GNU Make 4.2.1, but not seen with GNU Make 3.81. Fixes issue ARMmbed#3905.
Patater
approved these changes
Mar 8, 2017
AlessandroA
approved these changes
Mar 8, 2017
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
added
ready for merge
release-version: 5.4.1
and removed
needs: CI
ready for merge
release-version: 5.4.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
uvisorbuild issues observed with GNU Make 4.2.1, caused by missing dependencies and wildcard patterns in core libs targets' pre-requisites.Fixes issue #3905.
Tested successfully for building
uvisorandmbed-oswith GNU Make versions 4.2.1 and 3.81, with GCC_ARM toolchain version 6.3.0.Status
READY
Migrations
NO
Related PRs
None
Todos
Deploy notes
None
Steps to test or reproduce
Refer to issue #3905.