Skip to content

mbedtls/F439ZI: add md5 HASH feature #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

mbedtls/F439ZI: add md5 HASH feature #3950

wants to merge 4 commits into from

Conversation

adustm
Copy link
Member

@adustm adustm commented Mar 16, 2017

Description

Enable MD5 for STM32F439ZI
Add HW acceleratoin for MD5 on STM32F439ZI

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

YES | NO

Steps to test or reproduce

To test this feature, you have to modify TESTS/mbedtls/selfttest/main.cpp in order to call md5 self test:
add:
#include "mbedtls/md5.h"
then

#if defined(MBEDTLS_MD5_C)
MBEDTLS_SELF_TEST_TEST_CASE(mbedtls_md5_self_test)
#endif

then

#if defined(MBEDTLS_MD5_C)
    Case("mbedtls_md5_self_test", mbedtls_md5_self_test_test_case),
#endif

@adustm
Copy link
Member Author

adustm commented Mar 16, 2017

Question : I've added #define MBEDTLS_MD5_C in features/mbedtls/targets/TARGET_STM/TARGET_STM32F4/TARGET_NUCLEO_F439ZI/mbedtls_device.h
Is it OK ?

@adustm
Copy link
Member Author

adustm commented Mar 16, 2017 

+-------------------+---------------+------------------------+-----------------------------+--------+--------+--------+--------------------+
| target            | platform_name | test suite             | test case                   | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+------------------------+-----------------------------+--------+--------+--------+--------------------+
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_aes_self_test       | 1      | 0      | OK     | 0.55               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_base64_self_test    | 1      | 0      | OK     | 0.12               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_ccm_self_test       | 1      | 0      | OK     | 0.11               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_ctr_drbg_self_test  | 1      | 0      | OK     | 0.13               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_ecp_self_test       | 1      | 0      | OK     | 2.81               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_entropy_self_test   | 1      | 0      | OK     | 0.08               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_gcm_self_test       | 1      | 0      | OK     | 2.61               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_hmac_drbg_self_test | 1      | 0      | OK     | 0.06               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_md5_self_test       | 1      | 0      | OK     | 0.21               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_mpi_self_test       | 1      | 0      | OK     | 0.26               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_rsa_self_test       | 1      | 0      | OK     | 0.31               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_sha256_self_test    | 1      | 0      | OK     | 0.78               |
| NUCLEO_F439ZI-IAR | NUCLEO_F439ZI | tests-mbedtls-selftest | mbedtls_sha512_self_test    | 1      | 0      | OK     | 1.71               |
+-------------------+---------------+------------------------+-----------------------------+--------+--------+--------+--------------------+

@adustm adustm mentioned this pull request Mar 16, 2017
Closed
@0xc0170 0xc0170 requested a review from simonbutcher March 20, 2017 12:28
@0xc0170 0xc0170 requested review from yanesca and RonEld April 4, 2017 12:05
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2017

@adustm Please resolve the conflict

RonEld
RonEld reviewed Apr 4, 2017
View reviewed changes
targets/targets.json Outdated
@@ -903,7 +903,7 @@
"extra_labels": ["STM", "STM32F4", "STM32F439", "STM32F439ZI", "STM32F439xx", "STM32F439xI", "FLASH_CMSIS_ALGO"],
"supported_toolchains": ["ARM", "uARM", "GCC_ARM", "IAR"],
"progen": {"target": "nucleo-f439zi"},
"macros": ["TRANSACTION_QUEUE_SIZE_SPI=2", "MBEDTLS_CONFIG_HW_SUPPORT"],
"macros": ["TRANSACTION_QUEUE_SIZE_SPI=2", "MBEDTLS_CONFIG_HW_SUPPORT", "MBEDTLS_MD5_C"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as in #3956 THis is end user defined feature, which should be defined in mbed_app.json or user defined config.h

@adustm
Copy link
Member Author

adustm commented Apr 4, 2017

rebase done

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2017

@yanesca @RonEld pls review

@sg-
Copy link
Contributor

sg- commented Apr 10, 2017

@adustm Can this be moved against the workshop branch?

This was referenced Apr 11, 2017
Merged
Merged
@adustm adustm closed this Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonEld RonEld RonEld left review comments

@simonbutcher simonbutcher Awaiting requested review from simonbutcher

@yanesca yanesca Awaiting requested review from yanesca

Assignees
No one assigned
Labels
needs: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adustm @0xc0170 @sg- @RonEld