Fix for erroneous asserts #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fb90157, asserts were introduced changing the error checking style in large portions of the code base from `if(error_condition) fail();` to `assert(!error_condition);`. In doing so, not all boolean conditions were negated properly. This commit restores the original semantics of the error checks as they were before fb90157, (unless an error check has been changed upstream, in which case it is ignored). The practical effects of this commit is that it should restore proper I2C and SPI functionality on the LPC15XX and nRF51822, respectively.
Fix erroneous boolean expression conversions
0xc0170
added a commit
that referenced
this pull request
Jul 15, 2014
[HAL] Fix for asserts LPC15xx, NRF51822
yogpan01
pushed a commit
to yogpan01/mbed
that referenced
this pull request
Jul 21, 2016
for the ARM toolchain, disable/hide calls to printf()s from callback handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.