Skip to content

[Silicon Labs] Add flash HAL API support #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2017
Merged

[Silicon Labs] Add flash HAL API support #4037

merged 1 commit into from
Mar 29, 2017

Conversation

asmellby
Copy link
Contributor

Description

Implements the flash HAL API for EFM32 and EFR32.

Status

READY

Migrations

NO

Related PRs

List related PRs against other branches:

branch PR
Bugfix to flash API test #4036

Todos

  • Tests

Steps to test or reproduce

Run the flash HAL and flash IAP tests on any EFM32GG, WG, LG, PG1 or PG12, or EFR32MG1 or MG12 target. They pass if the test bugfix referenced above is applied.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 27, 2017 •
edited
Loading

The bugfix LGTM. we will wait for CI there, and integrate it

It would be nice to paste here some of the tests (at least on one device if possible for both flashIAP and flash HAL).

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 27, 2017

cc @c1728p9

@c1728p9
Copy link
Contributor

c1728p9 commented Mar 27, 2017

Looks good to me.

@asmellby
Copy link
Contributor Author

EFM32 Giant Gecko

mbedgt: test suite report:
+-------------------------+-----------------+-------------------------------------+--------+--------------------+-------------+
| target                  | platform_name   | test suite                          | result | elapsed_time (sec) | copy_method |
+-------------------------+-----------------+-------------------------------------+--------+--------------------+-------------+
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_drivers-flashiap | OK     | 10.53              | shell       |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_hal-flash        | OK     | 11.03              | shell       |
+-------------------------+-----------------+-------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK
mbedgt: test case report:
+-------------------------+-----------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                  | platform_name   | test suite                          | test case                     | passed | failed | result | elapsed_time (sec) |
+-------------------------+-----------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - init               | 1      | 0      | OK     | 0.0                |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - program            | 1      | 0      | OK     | 0.06               |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - program errors     | 1      | 0      | OK     | 0.0                |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_hal-flash        | Flash - buffer alignment test | 1      | 0      | OK     | 0.23               |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_hal-flash        | Flash - clock and cache test  | 1      | 0      | OK     | 0.16               |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_hal-flash        | Flash - erase sector          | 1      | 0      | OK     | 0.03               |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_hal-flash        | Flash - init                  | 1      | 0      | OK     | 0.16               |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_hal-flash        | Flash - mapping alignment     | 1      | 0      | OK     | 0.0                |
| EFM32GG_STK3700-GCC_ARM | EFM32GG_STK3700 | mbed-os-tests-mbed_hal-flash        | Flash - program page          | 1      | 0      | OK     | 0.12               |
+-------------------------+-----------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 9 OK
mbedgt: completed in 22.70 sec

EFM32 Pearl Gecko 1

mbedgt: test suite report:
+-------------------------+-----------------+-------------------------------------+--------+--------------------+-------------+
| target                  | platform_name   | test suite                          | result | elapsed_time (sec) | copy_method |
+-------------------------+-----------------+-------------------------------------+--------+--------------------+-------------+
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_drivers-flashiap | OK     | 11.08              | shell       |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_hal-flash        | OK     | 11.71              | shell       |
+-------------------------+-----------------+-------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK
mbedgt: test case report:
+-------------------------+-----------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                  | platform_name   | test suite                          | test case                     | passed | failed | result | elapsed_time (sec) |
+-------------------------+-----------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - init               | 1      | 0      | OK     | 0.0                |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - program            | 1      | 0      | OK     | 0.07               |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - program errors     | 1      | 0      | OK     | 0.0                |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_hal-flash        | Flash - buffer alignment test | 1      | 0      | OK     | 0.26               |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_hal-flash        | Flash - clock and cache test  | 1      | 0      | OK     | 0.19               |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_hal-flash        | Flash - erase sector          | 1      | 0      | OK     | 0.03               |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_hal-flash        | Flash - init                  | 1      | 0      | OK     | 0.19               |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_hal-flash        | Flash - mapping alignment     | 1      | 0      | OK     | 0.0                |
| EFM32PG_STK3401-GCC_ARM | EFM32PG_STK3401 | mbed-os-tests-mbed_hal-flash        | Flash - program page          | 1      | 0      | OK     | 0.14               |
+-------------------------+-----------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 9 OK
mbedgt: completed in 23.93 sec

EFM32 Pearl Gecko 12

mbedgt: test suite report:
+---------------------------+-------------------+-------------------------------------+--------+--------------------+-------------+
| target                    | platform_name     | test suite                          | result | elapsed_time (sec) | copy_method |
+---------------------------+-------------------+-------------------------------------+--------+--------------------+-------------+
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_drivers-flashiap | OK     | 11.01              | shell       |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_hal-flash        | OK     | 11.82              | shell       |
+---------------------------+-------------------+-------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK
mbedgt: test case report:
+---------------------------+-------------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                    | platform_name     | test suite                          | test case                     | passed | failed | result | elapsed_time (sec) |
+---------------------------+-------------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - init               | 1      | 0      | OK     | 0.0                |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - program            | 1      | 0      | OK     | 0.07               |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - program errors     | 1      | 0      | OK     | 0.0                |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_hal-flash        | Flash - buffer alignment test | 1      | 0      | OK     | 0.26               |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_hal-flash        | Flash - clock and cache test  | 1      | 0      | OK     | 0.19               |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_hal-flash        | Flash - erase sector          | 1      | 0      | OK     | 0.04               |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_hal-flash        | Flash - init                  | 1      | 0      | OK     | 0.18               |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_hal-flash        | Flash - mapping alignment     | 1      | 0      | OK     | 0.02               |
| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | mbed-os-tests-mbed_hal-flash        | Flash - program page          | 1      | 0      | OK     | 0.13               |
+---------------------------+-------------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 9 OK
mbedgt: completed in 23.95 sec

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 27, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1752

Build failed!

@asmellby asmellby changed the base branch from master to mbed-os-workshop-17q2 March 28, 2017 09:22
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 28, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1755

Test failed!

@bridadan
Copy link
Contributor

Hey everyone, the test failure was caused by an interface issue with one of the ST targets in our test farm. I have reset the target so that failure should be fixed now.

I am restarting the job...

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1765

All builds and test passed!

@sg- sg- merged commit 545a42f into ARMmbed:mbed-os-workshop-17q2 Mar 29, 2017
@c1728p9 c1728p9 mentioned this pull request Jun 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@asmellby @0xc0170 @c1728p9 @mbed-bot @bridadan @sg-