Skip to content

17q2 l4 flash #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 6, 2017
Merged

17q2 l4 flash #4058

merged 5 commits into from
Apr 6, 2017

Conversation

LMESTM
Copy link
Contributor

@LMESTM LMESTM commented Mar 28, 2017 •
edited by 0xc0170
Loading

This PR activates FLASH for L4 targets.

Flash hal tests running ok.

+-------------------+---------------+----------------------+--------+--------------------+-------------+
| target            | platform_name | test suite           | result | elapsed_time (sec) | copy_method |
+-------------------+---------------+----------------------+--------+--------------------+-------------+
| NUCLEO_L476RG-IAR | NUCLEO_L476RG | tests-mbed_hal-flash | OK     | 13.2               | shell       |
+-------------------+---------------+----------------------+--------+--------------------+-------------+
mbedgt: test suite results: 1 OK
mbedgt: test case report:
+-------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+
| target            | platform_name | test suite           | test case                     | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+
| NUCLEO_L476RG-IAR | NUCLEO_L476RG | tests-mbed_hal-flash | Flash - buffer alignment test | 1      | 0      | OK     | 0.24               |
| NUCLEO_L476RG-IAR | NUCLEO_L476RG | tests-mbed_hal-flash | Flash - clock and cache test  | 1      | 0      | OK     | 0.14               |
| NUCLEO_L476RG-IAR | NUCLEO_L476RG | tests-mbed_hal-flash | Flash - erase sector          | 1      | 0      | OK     | 0.06               |
| NUCLEO_L476RG-IAR | NUCLEO_L476RG | tests-mbed_hal-flash | Flash - init                  | 1      | 0      | OK     | 0.13               |
| NUCLEO_L476RG-IAR | NUCLEO_L476RG | tests-mbed_hal-flash | Flash - mapping alignment     | 1      | 0      | OK     | 0.05               |
| NUCLEO_L476RG-IAR | NUCLEO_L476RG | tests-mbed_hal-flash | Flash - program page          | 1      | 0      | OK     | 0.14               |
+-------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+

@0xc0170 0xc0170 requested a review from c1728p9 March 28, 2017 18:07
@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 28, 2017 •
edited by sg-
Loading

and FlashIAP tests ok as well

+-----------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
| target                | platform_name | test suite                  | test case                 | passed | failed | result | elapsed_time (sec) |
+-----------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
| NUCLEO_L476RG-GCC_ARM | NUCLEO_L476RG | tests-mbed_drivers-flashiap | FlashIAP - init           | 1      | 0      | OK     | 0.05               |
| NUCLEO_L476RG-GCC_ARM | NUCLEO_L476RG | tests-mbed_drivers-flashiap | FlashIAP - program        | 1      | 0      | OK     | 0.09               |
| NUCLEO_L476RG-GCC_ARM | NUCLEO_L476RG | tests-mbed_drivers-flashiap | FlashIAP - program errors | 1      | 0      | OK     | 0.06               |
+-----------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+

@sg-
Copy link
Contributor

sg- commented Mar 28, 2017

NUCLEO_L432KC doesn't seem to like device_has FLASH 👍 travis

@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 28, 2017

@sg- Fix pushed - should be fixed now

@sg- sg- mentioned this pull request Mar 28, 2017
Merged
0xc0170
0xc0170 reviewed Mar 29, 2017
View reviewed changes
targets/TARGET_STM/TARGET_STM32L4/flash_api.c
return 0;
}
}

Copy link
Contributor

@0xc0170 0xc0170 Mar 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doxygen comments are unnecessary (=maintenance) in code files if functions are public, the header file should contain those. In this case it does. Just document what is not there, any target specific differences

@0xc0170 0xc0170 removed the needs: CI label Mar 29, 2017
@LMESTM
Removing duplicate defines
3a3e98e 
Those defines are already available in STM32 L4 SDK and don't need to
be (re)defined here.
@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 29, 2017

@0xc0170 right - was useful when writing the first implementation and I forgot to remove them - done now

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 29, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1785

All builds and test passed!

0xc0170
0xc0170 reviewed Mar 30, 2017
View reviewed changes
targets/TARGET_STM/TARGET_STM32L4/flash_api.c Outdated
{
uint32_t page = 0;

if (Addr < (FLASH_BASE + FLASH_BANK_SIZE))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: code style in GetPage

@adbridge
Copy link
Contributor

@0xc0170 happy with changes ?

@adbridge
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1799

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 1, 2017

@mazimkhan Lot of PR within the last 2-3 days are red due to CAM CI (I checked, an exception). Can you have a look ? I restarted one to see if it is solved now.

@mazimkhan
Copy link

retest uvisor

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2017

retest uvisor

@sg- sg- merged commit bf81926 into ARMmbed:mbed-os-workshop-17q2 Apr 6, 2017
@c1728p9 c1728p9 mentioned this pull request Jun 6, 2017
Merged
@bcostm bcostm mentioned this pull request Dec 13, 2017
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@c1728p9 c1728p9 Awaiting requested review from c1728p9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LMESTM @sg- @0xc0170 @mbed-bot @adbridge @mazimkhan @bridadan