Skip to content

Improve error messages for bootloader build errors #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Mar 28, 2017

The error messages related to missing or broken device names in the
targets.json file were bad/just python tracebacks. This PR changes that
behavior, by having the Config object raise ConfigExceptions for those
mis-configurations.

Resolves #4057

Testing

  • Normal /morph test
  • Manual exercise of each corner case and verification that the
    messages seen are good.

Manual testing

  • mbed_app.json
{
    "target_overrides":{
        "NCS36510":{
            "target.restrict_size": "0x40000"
        }
    }
}
  • mbed compile -m NCS36510
[ERROR] Bootloader not supported on this target.
  • add "bootloader_supported": true to targets.json
  • mbed compile -m NCS36510
[ERROR] Bootloader not supported on this target: targets.json `device_name` not specified.
  • add "device_name": "NCS36510" to targets.json
  • mbed compile -m NCS36510
[ERROR] Bootloader not supported on this target: targets.json `device_name` not found in arm_pack_manager index.

@theotherjimmy
Copy link
Contributor Author

/morph test

@theotherjimmy theotherjimmy requested a review from 0xc0170 March 28, 2017 19:24
@sg-
Copy link
Contributor

sg- commented Mar 28, 2017

Need to change the base branch to mbed-os-workshop when CI completes

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1767

All builds and test passed!

@0xc0170 0xc0170 changed the base branch from master to mbed-os-workshop-17q2 March 29, 2017 10:44
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 29, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1781

All builds and test passed!

@theotherjimmy
Copy link
Contributor Author

@sg- Why did you want this retargeted? Are we planning on submitting the workshop branch as a PR after the workshop?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 29, 2017

@sg- Why did you want this retargeted? Are we planning on submitting the workshop branch as a PR after the workshop?

yes, we are.

@sg- sg- merged commit bdf13cb into ARMmbed:mbed-os-workshop-17q2 Mar 29, 2017
@theotherjimmy theotherjimmy deleted the better-bootloader-warning branch March 29, 2017 22:08
@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Mar 29, 2017

If we are merging the workshop branch into master, should that have been a rebase?

@theotherjimmy theotherjimmy restored the better-bootloader-warning branch March 29, 2017 22:09
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 29, 2017

If we are merging the workshop branch into master, should that have been a rebase?

yes, would have been easier. we will re-organize the branch a bit (not everything will go to master most likely) . There are some patches that will require further work (thus we are using a branch).

@theotherjimmy
Copy link
Contributor Author

Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants