-
Notifications
You must be signed in to change notification settings - Fork 3k
Improve error messages for bootloader build errors #4061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages for bootloader build errors #4061
Conversation
/morph test |
Need to change the base branch to mbed-os-workshop when CI completes |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
@sg- Why did you want this retargeted? Are we planning on submitting the workshop branch as a PR after the workshop? |
yes, we are. |
If we are merging the workshop branch into master, should that have been a rebase? |
yes, would have been easier. we will re-organize the branch a bit (not everything will go to master most likely) . There are some patches that will require further work (thus we are using a branch). |
Thanks for the clarification. |
The error messages related to missing or broken device names in the
targets.json file were bad/just python tracebacks. This PR changes that
behavior, by having the Config object raise ConfigExceptions for those
mis-configurations.
Resolves #4057
Testing
messages seen are good.
Manual testing
mbed_app.json
mbed compile -m NCS36510
"bootloader_supported": true
totargets.json
mbed compile -m NCS36510
"device_name": "NCS36510"
totargets.json
mbed compile -m NCS36510