Skip to content

K64F: Add MMCAU driver needed for mbedtls #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

mmahadevan108
Copy link
Contributor

Description

Include the MMCAU K64 SDK driver needed to supporting mbedtls

Status

**READY

@mmahadevan108
Copy link
Contributor Author

@sg- @0xc0170 @RonEld

@mmahadevan108
Copy link
Contributor Author

cc @MartinLatal

@RonEld
Copy link
Contributor

RonEld commented Mar 30, 2017

All the mbedtls related files should be in the features target, and not the mbed-os target (except entropy), so these files should be added to : features/mbedtls/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/ and not targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/

@mmahadevan108
Copy link
Contributor Author

Thank you. All the drivers associated with the hardware IP blocks are placed in the HAL drivers folder.

@0xc0170 0xc0170 requested review from simonbutcher and RonEld March 30, 2017 16:45
@mmahadevan108
Copy link
Contributor Author

Renamed the ARM library file to use the .ar extension.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2017

I restarted travis. Failed for not related change, lets review again once it finishes.

All the mbedtls related files should be in the features target, and not the mbed-os target (except entropy), so these files should be added to : features/mbedtls/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/ and not targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/

As these files are driver files, and those reside in hal under MCUXpresso folder, all good with this PR? Please review (there's one more PR for another targets).

Copy link
Contributor

@RonEld RonEld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would put the mbedtls related files in the mbedtls targets folder, but since all of the driver files are in the HAL I would keep them here as well

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2017

retest uvisor

@bridadan
Copy link
Contributor

bridadan commented Apr 4, 2017

/morph test-nightly

@mbed-bot
Copy link

mbed-bot commented Apr 5, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1830

Test failed!

@sg- sg- merged commit 3102469 into ARMmbed:mbed-os-workshop-17q2 Apr 10, 2017
@mmahadevan108 mmahadevan108 deleted the K64_MMCAU_Support branch April 14, 2017 15:52
Copy link

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Of course I did not review the binaries.

@daniel-cesarini-tridonic-com
Copy link

daniel-cesarini-tridonic-com commented Oct 29, 2018

@sg- @mmahadevan108 will the outcome of this workshop eventually make it into master?
We would be interested in this support for the hardware acceleration for security primitives in the K64 to come with mbed-os + mbedtls.
So, shall we expect this support anytime soon in mbed-os master, or shall we somehow pick the original branch and make it work on our own (not really preferred approach currently)?

FYI: @MarceloSalazar

Organization internal: @markus-becker-tridonic-com @andreas-myka-tridonic-com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants