LocalFileSystem: Repair the FileSystemLike hooks #4087

geky · 2017-03-30T20:44:40Z

Repaired the FileSystemLike hooks needed by the LocalFileSystem. This introduces FileSystemLike which is similar to FileLike, and FileSystemHandle which is similar to FileHandle.

To implement a FileSystemLike with error codes, the following functions must be implemented for file/dir lookup (only file is required):

int open(FileHandle **file, const char *filename, int flags);
int open(DirHandle **dir, const char *path);

This pr adopts the FileSystemLike into LocalFileSystem, FileSystem, and the retarget code. Hooks are provided by the common FileSystem layer, so no implementation needs to change.

This should resolve #3983, however is dependent on #3867, which restricts this to version 5.5.

should resolve: #3983
cause: https://github.com/ARMmbed/mbed-os/pull/3773/files
cc @simonqhughes, @kjbracey-arm, @bridadan

bridadan

Seems ok to me!

bridadan · 2017-04-03T16:51:18Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2017-04-03T19:34:21Z

[Build 1329]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

0xc0170 · 2017-04-04T11:42:40Z

features/filesystem/FileSystem.cpp

@@ -109,3 +123,37 @@ size_t FileSystem::dir_size(fs_dir_t dir)
    return size;
 }

+template <typename F>


worth documenting the intention with managed class ?

The previous one had // Internally used file objects with managed memory on close

0xc0170 · 2017-04-04T15:43:08Z

Jenkins CI failure:

[K64F ARM]   * K64F::ARM::FEATURES-FEATURE_LWIP-TESTS-MBEDMICRO-NET-GETHOSTBYNAME
[K64F ARM]         Building project gethostbyname (K64F, ARM)
[K64F ARM]         Scan: ARM
[K64F ARM]         Scan: FEATURE_LWIP
[K64F ARM]         Scan: FEATURE_STORAGE
[K64F ARM]         Scan: gethostbyname
[K64F ARM]         Compile [100.0%]: main.cpp
[K64F ARM]         [Warning] FileSystem.h@49,0:  #611-D: overloaded virtual function "mbed::FileSystemLike::open" is only partially overridden in class "mbed::FileSystem"
[K64F ARM]         Link: gethostbyname
[K64F ARM]         "/tmp/im5sfu", line 128 (column 3): Warning: L6312W: Empty Execution region description for region RW_IRAM1
[K64F ARM]         Error: L6218E: Undefined symbol mbed::FileSystem::open(mbed::Dir*, const char*) (referred from FileSystem.o).
[K64F ARM]         Error: L6218E: Undefined symbol mbed::FileSystem::open(mbed::File*, const char*, int) (referred from FileSystem.o).
[K64F ARM]         Finished: 0 information, 1 warning and 2 error messages.

kjbracey

Looks reasonable to me - abstract FileSystemHandle returning abstract FileHandle etc - but I've never looked that hard at the FileSystem bits, so I don't have much basis for comparison.

Seems like the API could work with a device filing system which is my current mental test.

geky · 2017-04-05T20:51:40Z

Thanks for catching those @0xc0170! Should be updated. I always get surprised by these compiler differences.

@kjbracey-arm, I've been keeping a device filing system in mind as well :)

bridadan · 2017-04-05T21:38:42Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2017-04-06T04:25:30Z

[Build 1336]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

sg- · 2017-04-10T16:51:01Z

This will need some serious docs work.

/morph test-nightly

mbed-bot · 2017-04-10T17:14:39Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

bridadan · 2017-04-11T14:38:11Z

/morph test-nightly

mbed-bot · 2017-04-11T18:06:15Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1881

Build failed!

bridadan · 2017-04-18T14:59:54Z

@geky We haven't replaced the Jenkins build data after upgrading the CI system, however the public build results are still available here: http://mbedosci.cloudapp.net/results/nightly/1881

geky · 2017-04-18T18:57:15Z

Updated with workaround, looks like some targets are defining an error_t type that conflicts with a standard type? Not worth fixing at the moment.
/morph test-nightly

mbed-bot · 2017-04-19T07:22:36Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 30

Test failed!

geky · 2017-04-19T16:35:48Z

Failures were related to networking issues last night, rerunning
/morph test-nightly

mbed-bot · 2017-04-20T04:02:11Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 41

Test failed!

adbridge · 2017-04-20T14:35:46Z

/morph test-nightly

bridadan · 2017-04-20T15:12:28Z

@geky Looks like travis actually failed on this one, can you take a look?

0xc0170 · 2017-06-02T13:48:38Z

/morph test-nightly

mbed-bot · 2017-06-02T15:18:21Z

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 420

Test failed!

geky · 2017-06-03T00:27:31Z

@0xc0170, thanks for the rebase 👍

more merge conflicts I take it?

sg- · 2017-06-03T04:48:55Z

@geky mind fixing the conflict?

0xc0170 · 2017-06-03T06:25:05Z

Rebased

sg- · 2017-06-03T15:15:03Z

/morph test

mbed-bot · 2017-06-03T15:28:09Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 428

Build failed!

c1728p9 · 2017-06-03T16:22:38Z

/morph test

mbed-bot · 2017-06-03T16:34:43Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 429

Build failed!

0xc0170 · 2017-06-03T16:50:14Z

retest uvisor

0xc0170 · 2017-06-03T16:57:12Z

Looks like we need to properly rebase ,retarget has errors (same was done with yesterday rebase?)

Required for other representations of FileSystems, ie LocalFileSystem Introduces FileSystemHandle for the same behaviour as FileHandle and DirHandle. Requires the following to hook into file/dir lookup: ``` int open(FileHandle **file, const char *filename, int flags) int open(DirHandle **dir, const char *path) ``` This hook is provided by the FileSystem class, so requires no changes from implementations.

The old open/opendir functions did not provide a route for errors and relied on implementations manually setting errno. Updated to return errors directly.

c1728p9 · 2017-06-03T18:20:01Z

I removed the MBED_CONF_FILESYSTEM_PRESENT ifdef around ManagedFile and ManagedDir. Also updated ManagedFile to inherit from FileHandle and ManagedDir to inherit from DirHandle.

c1728p9 · 2017-06-03T18:20:08Z

/morph test

mbed-bot · 2017-06-03T19:58:34Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 430

All builds and test passed!

geky · 2017-06-05T16:05:04Z

Thanks for the rebase! ManagedFile/ManagedDir are actually no longer used, but it's not like they will hurt master until we get around to removing them.

0xc0170 added the needs: review label Mar 31, 2017

geky force-pushed the localfs-fslike-fix branch from 98aa09f to 294ac38 Compare March 31, 2017 18:56

bridadan approved these changes Apr 3, 2017

View reviewed changes

0xc0170 requested review from simonqhughes and kjbracey April 4, 2017 11:40

0xc0170 reviewed Apr 4, 2017

View reviewed changes

kjbracey approved these changes Apr 5, 2017

View reviewed changes

geky mentioned this pull request Apr 5, 2017

Cellular feature br #4119

Merged

geky force-pushed the localfs-fslike-fix branch from 294ac38 to 5b68689 Compare April 5, 2017 20:50

geky mentioned this pull request Apr 6, 2017

Fixed compiler warning in mbed_retarget.cpp #4122

Merged

sg- added needs: CI and removed needs: review labels Apr 10, 2017

geky force-pushed the localfs-fslike-fix branch from 5b68689 to 59ab957 Compare April 18, 2017 18:53

sg- removed the needs: CI label Jun 2, 2017

0xc0170 force-pushed the localfs-fslike-fix branch from f15fd29 to ba30b32 Compare June 2, 2017 10:50

0xc0170 added needs: CI and removed needs: work labels Jun 2, 2017

0xc0170 force-pushed the localfs-fslike-fix branch from ba30b32 to 92c4384 Compare June 3, 2017 06:22

c1728p9 force-pushed the localfs-fslike-fix branch from 92c4384 to 5795373 Compare June 3, 2017 16:22

geky added 3 commits June 3, 2017 13:17

FileSystem: Provided default implementations for all non-file operations

eed1cec

LocalFileSystem: Moved away from deprecated open functions

0fc5ce2

The old open/opendir functions did not provide a route for errors and relied on implementations manually setting errno. Updated to return errors directly.

c1728p9 force-pushed the localfs-fslike-fix branch from 5795373 to 0fc5ce2 Compare June 3, 2017 18:19

sg- added ready for merge and removed needs: CI labels Jun 3, 2017

sg- merged commit 0da63ee into ARMmbed:master Jun 4, 2017

sg- removed the ready for merge label Jun 4, 2017

geky mentioned this pull request Jul 10, 2017

SDFileSystem example broken on mbed 2 library rev 138 or onward #4151

Closed

LocalFileSystem: Repair the FileSystemLike hooks #4087

LocalFileSystem: Repair the FileSystemLike hooks #4087

Uh oh!

Conversation

geky commented Mar 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

bridadan commented Apr 3, 2017

Uh oh!

mbed-bot commented Apr 3, 2017

Uh oh!

0xc0170 Apr 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Apr 4, 2017

Uh oh!

kjbracey left a comment

Choose a reason for hiding this comment

Uh oh!

geky commented Apr 5, 2017

Uh oh!

bridadan commented Apr 5, 2017

Uh oh!

mbed-bot commented Apr 6, 2017

Uh oh!

sg- commented Apr 10, 2017

Uh oh!

mbed-bot commented Apr 10, 2017

Uh oh!

bridadan commented Apr 11, 2017

Uh oh!

mbed-bot commented Apr 11, 2017

Output

Uh oh!

bridadan commented Apr 18, 2017

Uh oh!

geky commented Apr 18, 2017

Uh oh!

mbed-bot commented Apr 19, 2017

Output

Uh oh!

geky commented Apr 19, 2017

Uh oh!

mbed-bot commented Apr 20, 2017

Output

Uh oh!

adbridge commented Apr 20, 2017

Uh oh!

bridadan commented Apr 20, 2017

Uh oh!

0xc0170 commented Jun 2, 2017

Uh oh!

mbed-bot commented Jun 2, 2017

Output

Uh oh!

geky commented Jun 3, 2017

Uh oh!

sg- commented Jun 3, 2017

Uh oh!

0xc0170 commented Jun 3, 2017

Uh oh!

sg- commented Jun 3, 2017

Uh oh!

mbed-bot commented Jun 3, 2017

Output

Uh oh!

c1728p9 commented Jun 3, 2017

Uh oh!

mbed-bot commented Jun 3, 2017

Output

Uh oh!

0xc0170 commented Jun 3, 2017

Uh oh!

0xc0170 commented Jun 3, 2017

Uh oh!

c1728p9 commented Jun 3, 2017

geky commented Mar 30, 2017 •

edited

Loading

0xc0170 Apr 4, 2017 •

edited

Loading