u-blox rearrange ODIN target #4089
Conversation
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
Sporadic failure, restarting /morph test |
|
retest uvisor |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
The failure was caused by a board's interface getting into a bad state, restarting the tests now. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@andreaslarssonublox sorry but went though 'ready for merge' in oldest to newest and 4081 got merged before this. Kinda glad this happened because this is a restructure - can it hold off and be applied against master later in May once the workshop branch is merged? I fear there will be a divergence if we take this here any try to apply patches for this target between now and then |
|
Yes, we can wait! Also think it's better if we wait until all features(related to the workshop) for STM32F439xI have been done by ST and merged to master. |
|
bump @andreaslarssonublox Could you fix the merge conflicts? |
…easlarssonublox/mbed into ublox_rearrange_odin_target
# Conflicts: # targets/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/flash_api.c # targets/targets.json
|
@theotherjimmy I have merged in the latest now and resolved the conflicts. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Nice! |
|
@andreaslarssonublox you mentioned that this should come in before #4081, but it's already merged. Is this going to be a problem? |
|
@theotherjimmy It was the other way around. So it's the correct order. Sorry if the description was confusing. |
|
That's a-okay. I'm just happy that things worked out correctly |
Description
This PR pushes the ODIN-W2 target further down in the STM32F439xI target hierarchy to avoid duplicate code.
Status
This PR shall be merged before:
#4081
Migrations
NO
Related PRs
#4081
Todos
None
Deploy notes
Steps to test or reproduce
Test results
ublox_rearrange_odin_target_log_arm.txt
ublox_rearrange_odin_target_log_gcc.txt
ublox_rearrange_odin_target_log_iar_.txt