Move NRF52_DK target to NRF5_SDK13 sources #4132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCC_ARM, ARM, IAR tests results: |
What's is missing here? Can you specify what steps are require for this patch to be integrated? |
|
@nvlsianpu does the SDK13 will support the NRF51? |
|
SDK13 doesn't support NRF51. NRF51 is supported in SDK12.x.x. |
pan-
requested changes
Apr 12, 2017
targets/targets.json
Outdated
| @@ -2611,14 +2611,62 @@ | |||
| } | |||
| } | |||
| }, | |||
| "NRF52_DK": { | |||
| "NRF52_DK_LEGACY": { | |||
There was a problem hiding this comment.
There is no reason to keep this target if it is not used.
There was a problem hiding this comment.
I agree completely, no sense to keep legacy nrf52.
|
#4245 introduce combined NRF5 + NRF52840. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NRF52_DK is upgraded in order to using nRF5 SDK13 (common for nRF52840_DK).
Old implementation is switched to NRF52_DK_LEGACY.
NRF5_SDK13 is now ready to hosted all of nRF52 targets.
Status
IN DEVELOPMENT (PREVIEW)