Thread sec policy #4155
Thread sec policy #4155
Conversation
| | thread-config-channel-mask | number [0-0x07fff800] | Channel mask, 0x07fff800 scans all channels. | | ||
| | thread-config-channel-page | number [0, 2]| Channel page, 0 for 2,4 GHz and 2 for sub-GHz radios. | | ||
| | thread-config-channel | number [0-27] | RF channel to use. | | ||
| | thread-config-panid | number [0-0xFFFF] | Network identifier. | | ||
| | thread-config-network-name | string [1-16] | | ||
| | thread-config-commissioning-dataset-timestamp | [0-0xFFFFFFFFFFFFFFFF] | Timestamp where upper 48 bits are seconds | |
There was a problem hiding this comment.
Please check length of timestamp, is it 32 or 64bits?
| | thread-master-key | byte array [16]| Network master key. | | ||
| | thread-config-ml-prefix | byte array [8] | Mesh local prefix. | | ||
| | thread-config-pskc | byte array [16] | Pre-Shared Key for the Commissioner. | | ||
| | thread-security-policy | number [0-0xFF] | Security policy | |
| "thread-config-extended-panid": "{0xf1, 0xb5, 0xa1, 0xb2,0xc4, 0xd5, 0xa1, 0xbd }", | ||
| "thread-master-key": "{0x10, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, 0x88, 0x99, 0xaa, 0xbb, 0xcc, 0xdd, 0xee, 0xff}", | ||
| "thread-config-ml-prefix": "{0xfd, 0x0, 0x0d, 0xb8, 0x0, 0x0, 0x0, 0x0}", | ||
| "thread-config-pskc": "{0xc8, 0xa6, 0x2e, 0xae, 0xf3, 0x68, 0xf3, 0x46, 0xa9, 0x9e, 0x57, 0x85, 0x98, 0x9d, 0x1c, 0xd0}", | ||
| "thread-device-type": "MESH_DEVICE_TYPE_THREAD_ROUTER" | ||
| "thread-device-type": "MESH_DEVICE_TYPE_THREAD_ROUTER", | ||
| "thread-security-policy": 255 |
There was a problem hiding this comment.
let's leave one byte values as decimals
Minor changes
|
This is ready to me merged |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@karsev is this an API change? It looks like the security policy has been added and then given a default value. That sounds like something which would change behaviour of the system? |
|
The original setting was wrong causing an incorrect operation of the Thread network (router assignment). |
|
This is reliant on #3987 which is tagged for mbed-os-5.5.0 thus this also needs to be bumped to that release. |
|
Why this is taking so much time? Now, for example, mbed-os-example-client can fail if there is more than one device in the Thread network. |
What's the objection ? It was merged to master, will be part of 5.5 as stated above (dependencies). |
|
Ok, there was a documentation dependency included by mistake. |
Thread security policy can be now configured in .json. the default is set to 255.
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Steps to test or reproduce
Can be manually tested by observing Wireshark logs.